> On 29 May 2020, at 00:02, Elias Rudberg <elias.rudb...@bahnhof.net> wrote: > > I changed the fix using %U and a new unformat_l3_port function, as > suggested by Paul: > > https://gerrit.fd.io/r/c/vpp/+/27280
My opinion it’s an incorrect and unnecessary generalization/abstraction: 1) port is a L4 concept, not L3. Cf name. 2) no one said all L4 ports are/have to be a u16, or that the L4 has to have a concept of port. Don’t let TCP/UDP monoculture fool you. But, 🤷♂️. —a > > This works fine, but I wasn't sure where to put the unformat_l3_port > function. Now it's in vnet/udp/udp_format.c -- let me know if you have > a better idea about where it should be. > > / Elias
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16566): https://lists.fd.io/g/vpp-dev/message/16566 Mute This Topic: https://lists.fd.io/mt/74491544/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
