I think there are two issues. One issue is with APIs that were not intended to be Production yet. For ikev2 that basically means the version has been set [5] above 0.x.y only by mistake. As downgrading versions is always risky, marking messages as "In-Progress" instead is better.
The other issue is how to determine which APIs are really Production, and which are In-Progress with wrong version value. I believe every existing API should be reviewed, before we claim the new process [3] is applied. There are sub-issues, like who will decide, how much testing is needed, and how widespread a usage implies an API is effectively Production already. In contrast, the question of how to deal with Production APIs (existence of which hinders the work on legitimate improvements) is a non-issue. The new process has good reasons to force the expensive way with deprecation. Personally, I think it would be a good idea to mark ALL APIs as In-Progress, as it matches the (lack of) guarantees in previous releases, and let maintainers mark some messages as Production on their own pace. Vratko. [5] https://gerrit.fd.io/r/c/vpp/+/17803/3/src/plugins/ikev2/ikev2.api -----Original Message----- From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Benoit Ganne (bganne) via lists.fd.io Sent: Tuesday, 2020-June-16 18:29 To: vpp-dev@lists.fd.io Cc: Filip Tehlar -X (ftehlar - PANTHEON TECH SRO at Cisco) <fteh...@cisco.com>; Andrew Yourtchenko (ayourtch) <ayour...@cisco.com> Subject: [vpp-dev] ikev2 API & new API change process Hi all, The ikev2 plugin is currently getting some much needed love [1] [2] but it also means that its API is starting to show its age. We'd like to mark it as "In-Progress" under the new API change process [3] so that we can quickly improve it. The rationale is: - the requirement for an API to transition to "In-Production" is for the API to be stable and *tested* - there are currently no ikev2 unit test at all, and in fact the 1st proposed API change was motivated by the introduction of the initial test cases [4] - we are not aware of any users of the ikev2 plugin API today apart from the Calico-VPP integration Of course, a possibility would be to deprecate the existing one and to introduce a new one as "In-Progress" at the expense of more work. What does the community think here? Thanks ben [1] https://jira.fd.io/browse/VPP-1889 [2] https://jira.fd.io/browse/VPP-1904 [3] https://wiki.fd.io/view/VPP/ApiChangeProcess [4] https://gerrit.fd.io/r/c/vpp/+/27536
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16743): https://lists.fd.io/g/vpp-dev/message/16743 Mute This Topic: https://lists.fd.io/mt/74919923/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
