FWIW I looked at this briefly but started rat-holing trying to better integrate the python packaging (which I am somewhat familiar with) with cmake (which I know almost nothing about).
I think maybe the right thing to do here is create a custom cmake build rule to stage the entire python package in build-root/build* doing the pattern substitution on vpp_ffi.py.in as well as setup.py (to set a package_dir to point to the new staging location). Then the install rule would run "python setup.py install" inside that staging build dir with the arguments to install in the build-root/install* location (this latter rule is already there). This gets away from modifying files inside the source directory, as not modifying source directory files seems the expected behavior when using cmake. I'm not sure of the cmake magic to set dependencies correctly so that the custom build rule to copy the files gets invoked whenever a source python file changes, or ASAN is disabled or enabled, and how to carry those dependencies forward to the install rule. Thanks, Chris. > On Aug 7, 2020, at 12:01 PM, Benoit Ganne (bganne) via lists.fd.io > <[email protected]> wrote: > >> If I clear the runner (gitlab) cache it causes a full rebuild, and then I >> don't see the problem. >> Shouldn't the generated file be going under build-root? I ask b/c it's >> showing up in git status now. Maybe this also affects the cmake >> dependency? > > Hmm great point, I'll see how to fix that. > > Best > ben >
signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17196): https://lists.fd.io/g/vpp-dev/message/17196 Mute This Topic: https://lists.fd.io/mt/75917538/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
