Hi Sergey, have a look at 22963; the checkstyle job requires a particular version of checkstyle, it’s WIP in progress to update it, as well as to give us an option to selectively try out clang-format on some files.
However; I think this functionality of this patch has more fundamental question: it allows the use of the function that essentially renders the simple counter ambiguous in the way i see it as a user operationally: If the counter value is 42 - does it mean it was incremented to 10042 and then decremented by 10000 ? Or was it incremented by 10000000042 and then decremented by 10000000000 ? The only sensible operation for something that is the *counter*, is to either increment or reset to zero in my view. You should not be allowed to “uncount” stuff. However, if we are talking about a *gauge*, then it is a different story, and I suspect this may be the functionality you are after ? Like, the current number of connections tracked somewhere, etc ? --a >> On 15 Sep 2020, at 12:25, Sergey Matov <[email protected]> wrote: > > Greetings VPP community. > > Recently I've created a small patch for counter.h core file. > For some reason several patchsets are failing with checkstyle issues. > https://gerrit.fd.io/r/c/vpp/+/28843 > Fixing of the change by indent causes the entire file to be reworked since > the old file does not fit indent requirements. What is the best way to > process changes that fit the checkstyle but the original file does not? > Thanks in advance > > -- > Sergey Matov > > -- > > t: +49 391 819099-0 > > ------------------------------- enabling your networks > ----------------------------- > > Travelping GmbH > Roentgenstraße 13 > 39108 Magdeburg > Germany > > > t: +49 391 819099-0 > f: +49 391 819099-299 > > e: [email protected] > w: https://www.travelping.com/ > > Company registration: Amtsgericht Stendal > Managing Director: Holger Winkelmann > Reg. No.: HRB 10578 > VAT ID: DE236673780 >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17397): https://lists.fd.io/g/vpp-dev/message/17397 Mute This Topic: https://lists.fd.io/mt/76861769/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
