Like Damjan said, we use Gerrit. Those GitHub PR’s won’t be reviewed. I thought it used to say it was only a mirror, but doesn’t now. GitHub I think now allows us remove the option to create PR’s, perhaps we should make that so.
If you want to submit patches for review, details at https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code – anyone can sign up for an account with Linux Foundation and login to fd.io’s gerrit. Chris. From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Dimitrios Markou Sent: Monday, September 28, 2020 12:07 To: vpp-dev@lists.fd.io Subject: [EXTERNAL] [vpp-dev] Can I submit commit to vpp GitHub repo instead of gerrit? Hello all, I would like to ask if it is possible to create pull requests to the vpp github repo. I am not sure if I am allowed to do so or I must use only the gerrit path. I am asking because I am seeing couple pull requests in the github repo. https://github.com/FDio/vpp/pulls<https://urldefense.com/v3/__https:/github.com/FDio/vpp/pulls__;!!CQl3mcHX2A!Xt_SIZskZXAfS8ygKaYJV0OciqDrDcmd5til1F7inyx0q0Qa0ZMfrKW-m3dj-UiBiw$> Regards, Dimitris
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17560): https://lists.fd.io/g/vpp-dev/message/17560 Mute This Topic: https://lists.fd.io/mt/77178878/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
