OK, thanks for [0]. Even with the old debug CLI supported on the vpp side, the patch continues to fail validation. I’m going to try again (“recheck”) and see what happens.
D. From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via lists.fd.io Sent: Thursday, November 26, 2020 4:47 AM To: Dave Barach <v...@barachs.net> Cc: csit-...@lists.fd.io; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] Compatibility enhancement on CSIT side: [0]. > easy enough to support both “elog trace” and “event-logger trace” on the vpp > side. When [0] is merged (also to oper branch), the support on VPP side can be dropped. > add a binary API and use it in the csit robot framework +1 to that, especially if the API is marked as Production, so it is covered by [1]. Vratko. [0] <https://gerrit.fd.io/r/c/csit/+/30147> https://gerrit.fd.io/r/c/csit/+/30147 [1] <https://wiki.fd.io/view/VPP/ApiChangeProcess> https://wiki.fd.io/view/VPP/ApiChangeProcess From: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> <csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> > On Behalf Of Dave Barach Sent: Wednesday, 2020-November-25 22:42 To: csit-...@lists.fd.io <mailto:csit-...@lists.fd.io> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [csit-dev] event-logger debug CLI cleanup patch failing validation: [vpp gerrit 30124] <csit-workspace>/resource/libraries/python/VPPUtil.py appears responsible: @staticmethod def vpp_enable_elog_traces(node): """Enable API/CLI/Barrier traces on the specified topology node. :param node: Topology node. :type node: dict """ PapiSocketExecutor.run_cli_cmd_on_all_sockets( node, u"elog trace api cli barrier") For the moment, it’s easy enough to support both “elog trace” and “event-logger trace” on the vpp side. The obvious medium-term answer would be to add a binary API and use it in the csit robot framework, instead of depending on debug CLI [which is never a Good Idea]. FWIW... Dave
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18150): https://lists.fd.io/g/vpp-dev/message/18150 Mute This Topic: https://lists.fd.io/mt/78526554/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
