Indeed, it is not needed.
I previously removed it to compile on an old Intel CPU without sse4.2 and kept it for the Bluefield.

Thank you

On 2021/07/01 20:45, Damjan Marion wrote:

On 01.07.2021., at 07:35, Pierre Louis Aublin <pierrelo...@iij-ii.co.jp> wrote:

diff --git a/build/external/packages/ipsec-mb.mk 
b/build/external/packages/ipsec-mb.mk
index d0bd2af19..119eb5219 100644
--- a/build/external/packages/ipsec-mb.mk
+++ b/build/external/packages/ipsec-mb.mk
@@ -34,7 +34,7 @@ define  ipsec-mb_build_cmds
           SAFE_DATA=n \
           PREFIX=$(ipsec-mb_install_dir) \
           NASM=$(ipsec-mb_install_dir)/bin/nasm \
-         EXTRA_CFLAGS="-g -msse4.2" > $(ipsec-mb_build_log)
+         EXTRA_CFLAGS="-g" > $(ipsec-mb_build_log)
Why do you need this change?

If i get it right bluefield uses ARM cpus and we don’t compile intel ipsecmb 
lib on arm.

$ git grep ARCH_X86_64 build/external/Makefile
build/external/Makefile:ARCH_X86_64=$(filter x86_64,$(shell uname -m))
build/external/Makefile:install: $(if $(ARCH_X86_64), nasm-install 
ipsec-mb-install) dpdk-install rdma-core-install quicly-install libbpf-install
build/external/Makefile:config: $(if $(ARCH_X86_64), nasm-config 
ipsec-mb-config) dpdk-config rdma-core-config quicly-build

—
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19692): https://lists.fd.io/g/vpp-dev/message/19692
Mute This Topic: https://lists.fd.io/mt/83910198/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to