On Wed, Nov 23, 2022 at 12:25 PM filvarga <filipvarg...@gmail.com> wrote:
> Hi, > > Thank you for your notes and pointing out the issue. Feel free to submit > any changes in the future and add appropriate people to your review (based > on maintainers list). > Thanks, will do! For now I am posting a quick fix. As the nat44-ed control plane is > undergoing a continuous huge refactor I wouldn't advise too much diverting > from its current state.\ > I might point out that this applies to both ED and EI. They both display the same issues. > Better solution here is to check the return value of enable / disable > calls and then set rv appropriately. > Exactly. But in this case I couldn't because it was buried in a macro that didn't return. > For now (based on return codes from vnet/error.h) I will use these > VNET_API_ERROR_FEATURE_DISABLED > VNET_API_ERROR_UNSUPPORTED > for enable/disable api errors rather than introducing something new that > can get removed in near future. > Those error values miss the important case of identifying the case where one is trying to enable the already-enabled feature. We need to know and identify that case, just as many of the other Features do. Thanks, jdl
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22236): https://lists.fd.io/g/vpp-dev/message/22236 Mute This Topic: https://lists.fd.io/mt/95222842/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
