Hi VPP developers, Could someone please review this IPv4/IPv6 flow-hash change? https://gerrit.fd.io/r/c/vpp/+/46865
It includes the ICMP Echo identifier in flow hashes so that independent Echo sessions between the same IP endpoints can select different ECMP paths. The existing sport/dport masks are respected, and non-Echo ICMP hashing is unchanged. CI has passed (Verified +1). The change includes functional tests, and Ice Lake/GCC 14.3 microbenchmark results are documented in the review. I would also appreciate feedback on the explicit if/else structure versus the nested ternary alternative shown in the comments. Thanks, Timur Aitov
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#27210): https://lists.fd.io/g/vpp-dev/message/27210 Mute This Topic: https://lists.fd.io/mt/121467998/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
