On Fri, Jul 08, 2005 at 07:21:18PM +0200, Herbert Poetzl wrote:
> On Fri, Jul 08, 2005 at 11:32:03AM +0200, Enrico Scholz wrote:
> > [EMAIL PROTECTED] (Enrico Scholz) writes:
> > 
> > > | $ diet gcc x.c
> > > | $ strace ./a.out 
> > > | execve("./a.out", ["./a.out"], [/* 41 vars */]) = 0
> > > | old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, 
> > > -1, 0) = 0x97f47000
> > > | mremap(0x97f47000, 4096, 8192, MREMAP_MAYMOVE) = -1 ENOMEM (Cannot 
> > > allocate memory)
> > >                                                    ~~~~~~~~~
> > 
> > Is the
> > 
> > | @@ -351,8 +352,13 @@ unsigned long do_mremap(unsigned long ad
> > | ...
> > |         }
> > | -       if (!may_expand_vm(current->mm, (new_len - old_len) >> 
> > PAGE_SHIFT)) {
> > | +       if (!may_expand_vm(current->mm, (new_len - old_len) >> 
> > PAGE_SHIFT) ||
> > | +               vx_vmpages_avail(current->mm, (new_len - old_len) >> 
> > PAGE_SHIFT)) {
> > |                 ret = -ENOMEM;
> > 
> > hunk really correct, or is there missing a '!' before 'vx_vmpages_avail'?
> 
> well, that looks fishy, but a simple ! won't fix it ...

did I say that? D'oh! 

well, to my excuse, line wrapped commented diff hunks are hard to read ...

thanks again,
Herbert

> looking into it right now ...
> 
> thanks,
> Herbert
> 
> > Enrico
> 
> 
> 
> > _______________________________________________
> > Vserver mailing list
> > [email protected]
> > http://list.linux-vserver.org/mailman/listinfo/vserver
> 
> _______________________________________________
> Vserver mailing list
> [email protected]
> http://list.linux-vserver.org/mailman/listinfo/vserver
_______________________________________________
Vserver mailing list
[email protected]
http://list.linux-vserver.org/mailman/listinfo/vserver

Reply via email to