On Sun, Aug 31, 2003 at 10:57:42AM -0400, Rik van Riel wrote:
> I just started reading the vserver patch again and am now
> officially scared to hell:
> 
>         .long SYMBOL_NAME(sys_ni_syscall)       /* sys_free_hugepages */
>         .long SYMBOL_NAME(sys_ni_syscall)       /* sys_exit_group */
> +       .long SYMBOL_NAME(sys_new_s_context)
> +       .long SYMBOL_NAME(sys_set_ipv4root)
>         .long SYMBOL_NAME(sys_ni_syscall)       /* sys_lookup_dcookie */
>         .long SYMBOL_NAME(sys_ni_syscall)       /* sys_epoll_create */
> 
> This patch fragment to entry.S adds two syscalls into the
> middle of the table, shifting the syscalls below it to
> different numbers!

what shall I say ... depends on the patch 8-)

--- linux-2.4.22/arch/i386/kernel/entry.S       2003-06-13 16:51:29.000000000 +0200
+++ linux-2.4.22-ctx17a/arch/i386/kernel/entry.S        2003-08-25 03:16:10.000000000 
+0200
@@ -663,6 +663,8 @@
        .long SYMBOL_NAME(sys_ni_syscall)       /* sys_epoll_wait */
        .long SYMBOL_NAME(sys_ni_syscall)       /* sys_remap_file_pages */
        .long SYMBOL_NAME(sys_ni_syscall)       /* sys_set_tid_address */
+       .long SYMBOL_NAME(sys_new_s_context)
+       .long SYMBOL_NAME(sys_set_ipv4root)     /* 260 */
 
        .rept NR_syscalls-(.-sys_call_table)/4
                .long SYMBOL_NAME(sys_ni_syscall)

> Does vserver have reserved syscall numbers already ?

no ...

> If so, are there any plans to get them ?

we tried some time ago, but it wasn't possible ...
we also use the ILI flag in ext2/ext3 filesystems 8-)
(which by the way is also not reserved an clashes 
 with tail-marging)

> How about a sys_vserver multiplexer so we can easily add
> things like setting a new ipv6 root to the interface,
> without needing yet another syscall ?

good idea ... go ahead implement some stuff ...

best,
Herbert

> Rik
> -- 
> "Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it." - Brian W. Kernighan

Reply via email to