Hello Micke,

you are right, the is no real error checking in the code: Can you please try the following patch:

Index: Dumpfile.pm
===================================================================
--- Dumpfile.pm    (revision 319)
+++ Dumpfile.pm    (working copy)
@@ -803,6 +803,11 @@
    my $md5;
    $md5 = Digest::MD5->new if $self->{do_md5};

+    # prevent errors due to non existing files
+    if(!defined $text && defined $file && !-e $file) {
+        $text = "";
+    }
+
    # convert CRLF -> LF before calculating the size and compute the md5
    if(!defined $text && defined $file) {
       my ($input, $output);




Thanks for your other patch

Dirk






Micke schrieb:
Hi! at command was fixed in a recent update. Back on track using Fedora 7.

I did not use the attached patch as it seemed it was already in the
trunk. Results from r317:
* I failed to get any md5:s in the output file. In fact, when I
specified the --md5 switch the --trunkdir stopped working. I made the
following change:

Index: vss2svn.pl
===================================================================
--- vss2svn.pl  (revision 317)
+++ vss2svn.pl  (working copy)
@@ -1040,7 +1040,7 @@
     $action_sth = $gCfg{dbh}->prepare($sql);

     my $autoprops =
Vss2Svn::Dumpfile::AutoProps->new($gCfg{auto_props}) if $gCfg{auto_props};
-    my $dumpfile = Vss2Svn::Dumpfile->new($fh, $autoprops, $gCfg{do_md5});
+    my $dumpfile = Vss2Svn::Dumpfile->new($fh, $autoprops, $gCfg{md5});
     Vss2Svn::Dumpfile->SetTempDir($gCfg{tempdir});

 REVISION:
@@ -1165,6 +1165,7 @@
 Dumpfile     : $gCfg{dumpfile}
 VSS Encoding : $gCfg{encoding}
 Auto Props   : $gCfg{auto_props}
+MD5          : $gCfg{md5}


 VSS2SVN ver  : $VERSION

...and ran into the following:
$ tail vss2svn.log
Use of uninitialized value in array element at Vss2Svn/Dumpfile.pm line 185.
Use of uninitialized value in array element at Vss2Svn/Dumpfile.pm line 185.
Use of uninitialized value in array element at Vss2Svn/Dumpfile.pm line 185.
/home/micke/vss2svn-work/vss2svn4/trunk/ssphys/ssphys: no file delta
record found for check-in action (probably item did not retained old
versions of itself)
Try `/home/micke/vss2svn-work/vss2svn4/trunk/ssphys/ssphys --help` for
more information
ERROR -- FAILED with non-zero exit status 255 (cmd:
"/home/micke/vss2svn-work/vss2svn4/trunk/ssphys/ssphys" get -b -v1
--force-overwrite -ewindows-1252
"/home/micke/vss2svn-work/devsrc2/src2/devsrc2/data/w/wtqbaaaa"
./_vss2svn/vssdata/WT/WTQBAAAA)
at ./vss2svn.pl line 1345
binmode() on closed filehandle $input at Vss2Svn/Dumpfile.pm line 814.
No filehandle passed at Vss2Svn/Dumpfile.pm line 815.


Bedtime!
/Micke

_______________________________________________
vss2svn-users mailing list
Project homepage:
http://www.pumacode.org/projects/vss2svn/
Subscribe/Unsubscribe/Admin:
http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org
Mailing list web interface (with searchable archives):
http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user




_______________________________________________
vss2svn-users mailing list
Project homepage:
http://www.pumacode.org/projects/vss2svn/
Subscribe/Unsubscribe/Admin:
http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org
Mailing list web interface (with searchable archives):
http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user

Reply via email to