André Doherty wrote:
hello,

I would like to report a bug i found in ssphys that causes the whole process to fail.

In a somehow corrupted VSS database i am currently migrating to SVN, i meet some entries where the FORM FEED (0x0c) character is present in comments.

Unfortunately this character is not a valid XML character, when considered a white space (function isspace(0x0c) returns != 0), therefore the parsing of the XML produced by ssphys (info) fails.

I have patched the source code, so that this character would be skipped if encountered. Please find the patch attached to this email.

Thank you all for this nice piece of work, very useful and long live svn ;)

Thanks for the patch André. However, tinyxml is a 3rd party tool and since I'm not as familiar with C++ I'm hesitant to simply patch that file in our source.

Can anyone speak as to why the form feed character is not considered whitespace by isspace()? Maybe we should ask the tinyxml folks whether they would accept a patch to make their parser regard form feed as whitespace.

André, just for future reference, when submitting a patch to a project using SVN as version control, it's preferable to use "svn diff" to create patches since it makes it easier to apply.

thanks,
toby

_______________________________________________
vss2svn-users mailing list
Project homepage:
http://www.pumacode.org/projects/vss2svn/
Subscribe/Unsubscribe/Admin:
http://lists.pumacode.org/mailman/listinfo/vss2svn-users-lists.pumacode.org
Mailing list web interface (with searchable archives):
http://dir.gmane.org/gmane.comp.version-control.subversion.vss2svn.user

Reply via email to