Nico, On Fri, Mar 13, 2009 at 6:35 PM, Andres Riancho <andres.rian...@gmail.com> wrote: > Nicolas, > > On Fri, Mar 13, 2009 at 6:56 PM, Nicolas Rotta <nicolasro...@gmail.com> wrote: >> List, >> I've been working on this plug-in and it is now ready for your >> testing and comments. > > Thank you very much for your contribution, the plugin looks > *really* nice. Here are some comments: > > - The plugin worked, but it had a bug, where it flagged something as > existant, when it really was not. So I added a 404 check: > > if relative_distance( response.getBody(), > original_response.getBody() ) < 0.70\ > and not self.is404( response ): > > - I created a test script for the plugin (test scripts are located in > "scripts/"), to test the plugin against our test environment which is > available here [0]. If you are interested, I can send you a virtual > machine, with the test environment setup ready to run. > > The version I modified of slash.py is attached, together with the > "script-slash.w3af" file. Please review my changes, and commit these > two files to the SVN.
The next time, please use a meaningful SVN commit log message. >> It is my first contribution to the project, so don't >> be so harsh on me. > > We aren't harsh, we just try to keep high standards =) > >> Please, pay special attention to the relative_distance >> function usage. > > The relative_distance method sucks, I'll replace it's name and > usage by something more meaningful like "are_different()". > > Regarding the next task, if you have any doubts, just start a new > thread right here :) > > [0] https://w3af.svn.sourceforge.net/svnroot/w3af/extras/testEnv/ > > Cheers, >> >> Cheers, >> Nicolas Rotta >> >> ------------------------------------------------------------------------------ >> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are >> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and >> easily build your RIAs with Flex Builder, the Eclipse(TM)based development >> software that enables intelligent coding and step-through debugging. >> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com >> _______________________________________________ >> W3af-develop mailing list >> W3af-develop@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/w3af-develop >> >> > > > > -- > Andrés Riancho > http://www.bonsai-sec.com/ > http://w3af.sourceforge.net/ > -- Andrés Riancho http://www.bonsai-sec.com/ http://w3af.sourceforge.net/ ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ W3af-develop mailing list W3af-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/w3af-develop
