Andres,

> On Fri, Dec 23, 2011 at 7:19 AM, Taras<ox...@oxdef.info>  wrote:
>> Andres,
>>
>> currently only this comment is unresolved:
>>> #APR: I would like to see more doctests that represent the real use
>>> of this class. By that I mean that we should use
>>> setModValue() in the doctest instead of "m._mutant_dc =
>>> divided_path". The ideal would be to use it just like in fuzzer.py
>> In fuzzer.py we also use m._mutant_dc = divided_fname. Remember, I have made
>> URLParts on base of FileName part. Could you please point me one more time?
>
> Maybe we should change that to m.setDc( divided_fname ) ? It's not
> very nice to set a member like that.

Agree and will add it.

> Were you able to run the doctests? Do they all work?

Yep, I have ran it like this:
nosetests --with-doctest --doctest-tests --with-coverage 
--cover-package=core.data.fuzzer core/data/fuzzer

Name                                 Stmts   Miss  Cover   Missing
------------------------------------------------------------------
core.data.fuzzer                         0      0   100%
core.data.fuzzer.formFiller             32      0   100%
core.data.fuzzer.fuzzer                247    131    47%   84-165, 
177-256, 260-276, 287-304, 416, 436, 448, 480-483, 581-582, 603-607, 
614-615, 622-645
core.data.fuzzer.mutant                 75     37    51%   43, 46, 90, 
98-102, 105-111, 114-115, 118, 121, 132-135, 138, 155-172
core.data.fuzzer.mutantCookie           40     27    33%   32, 35, 50, 
53, 56, 59, 62, 68-71, 74-77, 84-99
core.data.fuzzer.mutantFileContent      22     16    27%   30, 33, 40, 47-64
core.data.fuzzer.mutantFileName         41     13    68%   40, 77, 85, 
88-90, 96, 99, 106-110
core.data.fuzzer.mutantHeaders          16      9    44%   30, 33, 36, 
39, 46-50
core.data.fuzzer.mutantJSON             13      8    38%   30, 33, 43-48
core.data.fuzzer.mutantPostData         21     15    29%   33, 40-57
core.data.fuzzer.mutantQs                8      1    88%   34
core.data.fuzzer.mutantUrlParts         41     13    68%   39, 50, 83, 
86-88, 94, 97, 104-108
core.data.fuzzer.mutantXMLRPC           13      8    38%   30, 33, 43-48
------------------------------------------------------------------
TOTAL                                  569    278    51%
----------------------------------------------------------------------
Ran 11 tests in 0.023s

OK


-- 
Taras
http://oxdef.info

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
W3af-develop mailing list
W3af-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/w3af-develop

Reply via email to