Tomas, On Fri, Oct 12, 2012 at 12:02 PM, Andres Riancho <andres.rian...@gmail.com> wrote: > Tomas, > > On Sun, Oct 7, 2012 at 2:55 PM, Tomas Velazquez > <tomas.velazqu...@gmail.com> wrote: >> Andres, >> >> I don't touch find_dvcs because it's a code of Adam Baldwin and I don't know >> if he let me change your code ... ok I will add my code to find_dvcs :) > > It is open source, and if you're improving it... nobody will complain. > > I'm not saying that you HAVE to use find_dvcs, I was just mentioning > that the plugins look alike and that before replacing one with the > other (or something similar) we should understand what each provides. > Note that we shouldn't leave both, that would only confuse users. > >> find_dvcs uses this strings to check existence of repositories: >> .git/HEAD >> .hg/requires >> .bzr/README >> >> I use the repository index files to check this. Should I keep these files >> previously mentioned? > > You should use the files you think are more convenient to reduce the > amount of HTTP requests and increase the quality of the detection. For > example, could .bzr/README be removed and the bzr repository still > work? Could the content be edited manually and make the detection fail > for that? In the case of the "repository index files" it sounds like > if you remove/edit those the repository will not work.
Did you have the time to merge these two plugins? I would love to review that code, add it to the threading2 branch and remove this from my TODO list :) Regards, >> Regards >> >> >> On Fri, Oct 5, 2012 at 9:44 PM, Andres Riancho <andres.rian...@gmail.com> >> wrote: >>> >>> List, Tomas, >>> >>> > - >>> > https://code.google.com/p/tvelazquez/source/browse/pentest/w3af-plugins/crawl/rcs.py >>> >>> I noticed that this is an improvement for find_dvcs [0], which adds >>> features for detecting SVN, CVS, etc. and also parsing some of the >>> identified files; neat! What else is in this file? Why a rewrite >>> instead of just adding stuff to find_dvcs? >>> >>> [0] >>> https://sourceforge.net/apps/trac/w3af/browser/branches/threading2/plugins/crawl/find_dvcs.py >>> >>> Regards, >>> -- >>> Andrés Riancho >>> Project Leader at w3af - http://w3af.org/ >>> Web Application Attack and Audit Framework >>> Twitter: @w3af >>> GPG: 0x93C344F3 >> >> > > > > -- > Andrés Riancho > Project Leader at w3af - http://w3af.org/ > Web Application Attack and Audit Framework > Twitter: @w3af > GPG: 0x93C344F3 -- Andrés Riancho Project Leader at w3af - http://w3af.org/ Web Application Attack and Audit Framework Twitter: @w3af GPG: 0x93C344F3 ------------------------------------------------------------------------------ The Windows 8 Center - In partnership with Sourceforge Your idea - your app - 30 days. Get started! http://windows8center.sourceforge.net/ what-html-developers-need-to-know-about-coding-windows-8-metro-style-apps/ _______________________________________________ W3af-develop mailing list W3af-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/w3af-develop
