On 2012-08-13 17:11, Jordan Justen wrote:
When running gl_basic under X, I have to be root, however, if I switch
to a virtual console, this is not required.

Do you guys ever want to run within X? At least for the kernel testing case we can safely abort whenever we can't be the DRM_MASTER.


This series is available at:
ssh://people.freedesktop.org/~jljusten/waffle.git gbm-v2

Cool. Have you tried to run piglit without X yet?


--

v2:
* gbm_display_connect: attempt to open specified name before searching
   for devices via libudev.
 * cleanup various wayland references
 * add libudev to cmake

v1:
 * gl_basic appears to function

Series is looking good to me. I don't really want to review patch 3 very closely as I find it painful that Chad did this in C (and that's coming from someone who hates C++).

Acked-by from me for sure. If you *really* need review on patch3, I can try to find time; but that's by request only. What is planned next?


Jordan Justen (4):
  CMakeLists: print includedir
  gl_basic: print a message if gl_basic is successful
  gbm: initial functional gbm support
  gl_basic: add gbm support

 CMakeLists.txt                   |   25 +++++-
 examples/gl_basic.c              |    4 +-
 include/waffle/waffle_config.h   |    2 +
 include/waffle/waffle_enum.h     |    1 +
 src/waffle/CMakeLists.txt        |   16 ++++
 src/waffle/api/waffle_init.c     |    8 ++
 src/waffle/gbm/gbm_config.c      |  109 +++++++++++++++++++++++
 src/waffle/gbm/gbm_config.h      |   58 ++++++++++++
 src/waffle/gbm/gbm_context.c     |  114 ++++++++++++++++++++++++
 src/waffle/gbm/gbm_context.h     |   51 +++++++++++
 src/waffle/gbm/gbm_display.c     |  181
++++++++++++++++++++++++++++++++++++++
 src/waffle/gbm/gbm_display.h     |   59 +++++++++++++
src/waffle/gbm/gbm_platform.c | 137 +++++++++++++++++++++++++++++
 src/waffle/gbm/gbm_platform.h    |   49 +++++++++++
 src/waffle/gbm/gbm_priv_egl.c    |   29 ++++++
 src/waffle/gbm/gbm_priv_egl.h    |   30 +++++++
src/waffle/gbm/gbm_window.c | 144 ++++++++++++++++++++++++++++++
 src/waffle/gbm/gbm_window.h      |   53 +++++++++++
 tests/functional/gl_basic_test.c |   52 +++++++++++
 19 files changed, 1117 insertions(+), 5 deletions(-)
 create mode 100644 src/waffle/gbm/gbm_config.c
 create mode 100644 src/waffle/gbm/gbm_config.h
 create mode 100644 src/waffle/gbm/gbm_context.c
 create mode 100644 src/waffle/gbm/gbm_context.h
 create mode 100644 src/waffle/gbm/gbm_display.c
 create mode 100644 src/waffle/gbm/gbm_display.h
 create mode 100644 src/waffle/gbm/gbm_platform.c
 create mode 100644 src/waffle/gbm/gbm_platform.h
 create mode 100644 src/waffle/gbm/gbm_priv_egl.c
 create mode 100644 src/waffle/gbm/gbm_priv_egl.h
 create mode 100644 src/waffle/gbm/gbm_window.c
 create mode 100644 src/waffle/gbm/gbm_window.h

--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
waffle mailing list
waffle@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/waffle

Reply via email to