Juha and Arun, I posted this patch on a temporary branch for your testing 'tmp-android-fixes'.
https://github.com/chadversary/waffle/commits/tmp-android-fixes After Juha-Pekka tests the patch, I'll commit. -Chad On Fri, Feb 28, 2014 at 12:14:38PM +0530, Arun Sl wrote: > Hello Juha, > > Please find the patch I have come up with. > > > Thanks & Regards > Arun S L > > > From: Juha-Pekka Heikkilä <juha-pekka.heikk...@linux.intel.com> > To: "Arun Sl" <arun...@tcs.com> > Cc: waffle@lists.freedesktop.org > Date: 02/27/2014 06:14 PM > Subject: Re: [waffle] waffle for android-4.1.2_r1 > > > ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ > > > > Hi Arun, > > In the beginning of the file droid_surfaceflingerlink.cpp you can see how > to juggle with the different Android versions using #if/#else's. Would be > superb if you could make your fix into a patch format, I can test it on > JellyBean Android how it work there. > > /Juha-Pekka > > On Thu, February 27, 2014 12:08 pm, Arun Sl wrote: > > Hello Again, > > > > Just fixed the issue: > > > > This seems to be something to do with the order in which the arguments are > > given to createSurface that was causing the issue. > > > > pANWContainer->surface_control = > > pSFContainer->composer_client->createSurface( > > String8("Waffle Surface"),0, > > droid_magic_surface_width, droid_magic_surface_height, > > PIXEL_FORMAT_RGB_888); > > > > Now this is solved. > > But the code need to branch based on Android version make it work on old > > android versions as well as newer ones. > > > > Thanks & Regards > > Arun S L > > > > > > > > From: > > Arun Sl/HYD/TCS > > To: > > waffle@lists.freedesktop.org > > Date: > > 02/27/2014 03:12 PM > > Subject: > > waffle for android-4.1.2_r1 > > > > > > Hello, > > > > I have tried latest waffle against android-4.1.2_r1 but it segfaults. > > > > So to avoid the same, I did make the following changes: > > > > struct wcore_window* > > droid_window_create(struct wcore_platform *wc_plat, > > struct wcore_config *wc_config, > > int width, > > int height) > > { > > struct droid_window *self; > > struct wegl_config *config = wegl_config(wc_config); > > struct droid_display *dpy = droid_display(wc_config->display); > > bool ok = true; > > > > self = wcore_calloc(sizeof(*self)); > > if (self == NULL) > > return NULL; > > > > self->pANWContainer = droid_create_surface(width, height, > > dpy->pSFContainer); > > if (!self->pANWContainer) > > goto error1; > > > > ok = wegl_window_init(&self->wegl, wc_config, > > (intptr_t) *((intptr_t*)(self->pANWContainer))); > > if (!ok) > > goto error; > > > > return &self->wegl.wcore; > > > > error: > > droid_window_destroy(&self->wegl.wcore); > > error1: > > return NULL; > > } > > > > The waffle is still not working against even gl_basic, I am getting the > > following error: > > > > gl_basic --platform=android --api=gles2 > > gl_basic: error: WAFFLE_ERROR_UNKNOWN: Unable to get > > android::SurfaceControl > > > > Can anyone guide me here? > > > > Thanks & Regards > > Arun S L > > > > =====-----=====-----===== > > Notice: The information contained in this e-mail > > message and/or attachments to it may contain > > confidential or privileged information. If you are > > not the intended recipient, any dissemination, use, > > review, distribution, printing or copying of the > > information contained in this e-mail message > > and/or attachments to it are strictly prohibited. If > > you have received this communication in error, > > please notify us by reply e-mail or telephone and > > immediately and permanently delete the message > > and any attachments. Thank you > > > > > > _______________________________________________ > > waffle mailing list > > waffle@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/waffle > > > > > > _______________________________________________ > waffle mailing list > waffle@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/waffle _______________________________________________ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle