On 12/21/2014 01:28 PM, Emil Velikov wrote: > On 21 December 2014 at 14:22, Emil Velikov <[email protected]> wrote: >> On 16 December 2014 at 08:18, Chad Versace <[email protected]> >> wrote: >>> When designing the original Waffle 1.0 API, I made a mistake when >>> I chose to declare attribute lists as arrays of int32_t. Instead, they >>> should have been arrays of intptr_t. >>> >>> A new public function, waffle_window_create2, will have a `const >>> intptr_t attrib_list[]` parameter. Therefore waffle needs intptr_t >>> variants of the wcore_attrib_list functions. >>> >>> Signed-off-by: Chad Versace <[email protected]> >>> --- >>> src/waffle/core/wcore_attrib_list.c | 73 >>> +++++++++++++++++++++++++++++++++++++ >>> src/waffle/core/wcore_attrib_list.h | 23 ++++++++++++ >>> 2 files changed, 96 insertions(+) >>> >>> diff --git a/src/waffle/core/wcore_attrib_list.c >>> b/src/waffle/core/wcore_attrib_list.c >>> index 09a4dec..a7f087d 100644 >>> --- a/src/waffle/core/wcore_attrib_list.c >>> +++ b/src/waffle/core/wcore_attrib_list.c >>> @@ -29,6 +29,79 @@ >>> #include <stdint.h> >>> #include <stddef.h> >>> >>> +size_t >>> +wcore_attrib_list_length(const intptr_t attrib_list[]) >>> +{ >>> + const intptr_t *i = attrib_list; >>> + >>> + if (attrib_list == NULL) >>> + return 0; >>> + >>> + while (*i != 0) >>> + i += 2; >>> + >>> + return (i - attrib_list) / 2; >> Guessing that 2 is meant sizeof(intptr_t). If so can we use it ? >> Similar request for the other 2's in this patch. >> > Scratch that - seems like I was in the clouds. We're talking about > key/value pairs.
Yup. In return, please ignore my reply to your other email :)
signature.asc
Description: OpenPGP digital signature
_______________________________________________ waffle mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/waffle
