Sorry for the delay. I flagged this email, but then forgot about it, to only find it again now.

Patch looks good and builds fine.

Reviewed-by: Jose Fonseca <[email protected]>

Jose

On 06/12/14 00:52, Chad Versace wrote:
To create an ES2 context, Waffle required
WGL_EXT_create_context_es2_profile. Fix Waffle to require either
WGL_EXT_create_context_es_profile *or*
WGL_EXT_create_context_es2_profile, because
WGL_EXT_create_context_es_profile is an updated variant of
WGL_EXT_create_context_es2_profile that supercedes it.

Cc: José Fonseca <[email protected]>
Cc: Emil Velikov <[email protected]>
Fixes #23: 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_waffle-2Dgl_waffle_issues_23&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=5fmQ5w_Dy43fhC0ykaKcKMty48N6X7EEst9KKscTJ1U&s=zIqRdTM0gI7dO2XWOAEibdFaoaP5T2VvvujYr9jX8Vs&e=
Signed-off-by: Chad Versace <[email protected]>
---

Totally untested. I don't have MinGW setup right now. Windows people, please
let know if this patch compiles.

  src/waffle/wgl/wgl_config.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/waffle/wgl/wgl_config.c b/src/waffle/wgl/wgl_config.c
index 9dea991..59a70a6 100644
--- a/src/waffle/wgl/wgl_config.c
+++ b/src/waffle/wgl/wgl_config.c
@@ -118,8 +118,10 @@ wgl_config_check_context_attrs(struct wgl_display *dpy,
              assert(attrs->context_major_version == 2);
              assert(!attrs->context_forward_compatible);

-            if (!dpy->EXT_create_context_es2_profile) {
+            if (!dpy->EXT_create_context_es2_profile
+                && !dpy->EXT_create_context_es_profile) {
                  wcore_errorf(WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM,
+                             "WGL_EXT_create_context_es_profile or "
                               "WGL_EXT_create_context_es2_profile is required "
                               "to create an OpenGL ES2 context");
                  return false;


_______________________________________________
waffle mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/waffle

Reply via email to