On 12/28/2014 11:11 PM, Tapani Pälli wrote: > > > On 12/23/2014 12:28 AM, Chad Versace wrote: >> On 12/21/2014 07:53 AM, Emil Velikov wrote: >>> On 17 December 2014 at 10:17, Tapani Pälli <[email protected]> wrote: >>>> Patch adds changes required to use NaCl compiler and libraries to >>>> build Waffle. Build can be configured to use specific version of >>>> the NaCl SDK, toolchain for the build needs to be selected with >>>> cmake variable CMAKE_TOOLCHAIN_FILE.
>>>> + if(NOT EXISTS ${CMAKE_TOOLCHAIN_FILE})
>>>> + message(FATAL_ERROR "Toolchain for Nacl not found. This must
>>>> be "
>>>> + "configured using CMAKE_TOOLCHAIN_FILE.")
>>>> + endif()
>>>> +
>>> Don't think we need this check, but I'll leave it up-to Chad to be the
>>> final judge.
>>
>> Correct. CMake validates CMAKE_TOOLCHAIN_FILE very early during
>> configuration.
>> If I understand correctly, CMake validates it before reading any of the
>> project's CMake files.
>
> I added the check to make sure that nacl is only compiled with the toolchain
> files, otherwise the build will fail. For example if you leave it out from
> the example line in commit message, build fails and error message for user is
> a missing header.
Ok. That makes sense.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ waffle mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/waffle
