On 4 January 2015 at 22:02, Chad Versace <[email protected]> wrote: > This patch series is available at > git://github.com/chadversary/waffle refs/tags/waffle_window_create2-v02 > > Today, waffle_window() has only two parameters: width and height. > > Frank Henigman wants to extend Waffle's GBM backend with the ability to > post window contents to the display. Multiple methods exist for posting > content to the screen with the drm API, and that method should be > configurable per waffle_window. Therefore, we need to be able to pass > additional attributes to waffle_window_create(). > > It would also be nice to specify at time of creation that the > waffle_window should be full screen. Again, we need to pass additional > attributes to waffle_window_create(). > > The new function waffle_window_create2() is conceptually equivalent to > the original waffle_window_create() with the addition of an attrib_list > parameter. The only supported attributes are currently > WAFFLE_WINDOW_WIDTH and WAFFLE_WINDOW_HEIGHT. > > I tested the new function on GLX, X11/EGL, Wayland, and GBM. > > I have not yet tested the build on Windows, Android, or Mac. Before merging > this series, I will ensure it doesn't break the build on those platforms. I > don't have the ability to actually test on Android or Windows, though. > > v2: > - Deprecate public waffle_attrib_list functions. > - Remove code duplication between int32_t and intpr_t variants of > wcore_attrib_list functions. [requested by fjhenigman] > - Implement waffle_window_create by calling waffle_window_create2. > [fjhenigman] > - Be smarter about arithmetic overflows when allocating memory. > - Handle malloc failure. [emil] > - Fix some #include placements. [emil] > Hi Chad,
I've just send a couple of updates to get things working for WGL/MSVC. With those applied on top of your waffle_window_create2 branch (top commit 1b9a56659c7021265a468f1b238b4591e6f702a1), make check, check-fun and the gl_basic+wflinfo work like a charm. For the series Tested-by: Emil Velikov <[email protected]> (msvc/wgl) Reviewed-by: Emil Velikov <[email protected]> Jose, Can you give the series a spin on your end ? I have left the MSVC fixes separate, but I assume Chad will squash them prior to merging. You can fetch the lot from https://github.com/evelikov/waffle/commits/waffle_window_create2 Note that piglit does not use the new API, so it's a matter of running make check/check-func and/or spotting any regressions (in piglit/apitrace) Cheers, Emil _______________________________________________ waffle mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/waffle
