On Sat 15 Aug 2015, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> > --- > src/waffle/gbm/wgbm_display.c | 8 ++++++++ > 1 file changed, 8 insertions(+)
Hi Ilia, The patch, as-is, silently falls back to searching udev if it fails to open the device path given in the environment. I think that's an unexpected and surprising failure mode, because the user thinks one device was opened (the one in the environment) but is given no indication that a different device was opened. Like we discussed in IRC, I made a few changes to the patch, and also fixed the silent failure mode. It's in master now [1]. And I'll add it to 1.5.2 too (I'm preparing the release notes right now). [1]: https://github.com/waffle-gl/waffle/commit/cef67496e379b660601f64ab2ddf7cf06307b8aa _______________________________________________ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle