On 21 April 2016 at 21:27, Frank Henigman <fjhenig...@google.com> wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments.
> Would also be nice if Chad merged his get-current branch > into master, as I use it in v2. > Would be nice to see the series fly by the ML, although from a quick look they look great. We could use it to resolve some nasty implementations details in nacl/android/others and get GBM's window_resize working. > When comparing my json output to the landed json output I noticed that > the landed version omits the context flags found in the old format. > Was that deliberate? If so I'll remove it from my json. > I'll refer Chad to that one. > Not sure if I did the right thing with glx info. Seems like all three > sections (server, client, common) show about the same list of > extensions. That may be true for some vendors, but it's not the rule afaict. On my systems running mesa + i965 and nouveau the lists do differ. How useful the separate lists are is another topic ;-) > That can wait until I send v2, or if anyone wants to look > now: > https://github.com/fjhenigman/waffle/commit/b358ac50c00ce51fae6546b1e96c9adc32fcbdc7 I've not looked in details in the github branch, but considering that wcore_[cm]alloc is used (instead of [cm]alloc or strdup), the leak is plugged and people are happy with the other two topics (loose common GL data, even if we fail in print_platform_specific) (don't print anything and/or error if print_platform_specific() is not implemented), I'd say just do with the series. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Emil _______________________________________________ waffle mailing list email@example.com https://lists.freedesktop.org/mailman/listinfo/waffle