Author: muggenhor
Date: Thu Mar 15 18:50:53 2007
New Revision: 876
URL: http://svn.gna.org/viewcvs/warzone?rev=876&view=rev
Log:
* make soundSource be a direct composite member of soundStream (rather than
just a pointer to soundSource)
** this improves access of the soundSource member by
0 eliminating one pointer dereference call;
0 enabling the compiler to skip the virtual table of soundSource when calling
one of its virtual member functions;
0 and enabling the compiler to inline virtual function calls to virtual
member functions of soundSource
** secondly this moves the responsibility for construction of soundSource to
soundStream rather than the usercode of soundStream
*** this does result however in soundStream requiring to know in which
soundContext it exists (it originally couldn't exist in more than one anyway,
so besides a change
* soundSource source; member of soundStream is now public, this might change
in the future (i.e. writing interface functions for them rather than allowing
direct access which compromises object encapsulation)
in constructor semantics this doesn't change anything significant)
* remove 2D setting from soundSource's constructor (it isn't anymore required
to be known at construction time, and besides that really doesn't belong there)
Modified:
branches/sound/lib/sound/interface.cpp
branches/sound/lib/sound/openal/source.cpp
branches/sound/lib/sound/openal/source.hpp
branches/sound/lib/sound/stream.cpp
branches/sound/lib/sound/stream.hpp
_______________________________________________
Warzone-commits mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-commits
