Am Sonntag, 17. September 2006 20:39 schrieb Christian Ohm: > On Sunday, 17 September 2006 at 12:29, Dennis Schridde wrote: > > Am Sonntag, 17. September 2006 01:39 schrieb Christian Ohm: > > > The attached patch makes Warzone almost compile with "g++ > > > -fpermissive". It contains mainly explicit casts, some type changes, a > > > few fixes. In other words, just code cleanup. Comments in the next > > > mail. > > > > - The malloc casts are ok, as is the void* -> void** casting. > > - You use some uint8... Where do they come from? (I thought we had no > > uintX anywhere anymore.) > > I don't know where they came from, it was imported that way from the > Berlios SVN. I changed it now to UBYTE, since those types are used > throughout the source. See below.
> > - You do a lot of xxx_TYPE casting. I guess it's not possible to do that > > without casting? (The code doesn't look so.) > > Nope. In C, the casting is done implicitly, but in C++ you have to cast > things explicitely. The casts I've added don't change anything, they > just tell the C++ compiler to do what the C compiler already does > automatically. k. Those enums looked different to me, but when looking more thoroughly I see that SCR_TYPES is an extension to INTERP_TYPES. Dunno if that is good, but probably not that easy to change and would need further investigation whether it is sensible to change it. > > And as you are changing types anyway: We don't want to use MS types, > > neither do we want to use stdint types. I think it is best if we only use > > SDL types whereever we need a fixed size or have API calls. Is it > > possible to take that into account in those patches or would that break > > yet again? > > Well, I have now used the type from lib/framework/types.h, for > consistency. We could change the typedefs in lib/framework/types.h to > use the SDL types, so the size of the integers is the same on all > platforms, but I wouldn't use them in the code (unless we change _all_ > variables). Why not use SDL types where we write code and constantly change the other types till we have only SDL types one day? Because if we define the MS types to SDL types and the SDL types are not exactly what the MS types were, then ... b00m ... --Dennis
pgpW4rLxdn6oM.pgp
Description: PGP signature
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
