On Tue, 26 Jun 2007 09:55:17 -0400 Giel van Schijndel 
<[EMAIL PROTECTED]> wrote:
>Giel van Schijndel schreef:
>> [EMAIL PROTECTED] schreef:
>>   
>>> Sorry, I no know that physfs no auto convert / & \.  I use 
>>> PHYSFS_getDirSeparator() now.
>>>
>>> This patch fix problem for linux. (tested)
>>> ***DELETE ALL *.sta in multiplay\players !!
>>> on windows, it is in profile directory dir for warzone.
>>> on linux it is ~/.warzone I thinks it was.
>>>   
>>>     
>> Firstly you use PHYSFS_addToSearchPath, you simply shouldn't 
>touch any
>> part of the search path after initialization.
>>
>> Then there are some other problems with this patch one of them 
>being
>> that it won't work with any other files than the ".sta" files 
>(and this
>> function is meant to work with more). Also it assumes that all
>> directories always only contain the correct files (i.e.
>> multiplay/players is _always_ expected to contain *.sta files 
>only,
>> which is a dangerous assumption.
>>
>> Anyway apart from that this patch did inspire me to rewrite this
>> function entirely myself. So thanks for pointing out the 
>problem.
>>   
>PS Looking at your patch I'm getting to think that you somehow 
>where
>reluctant to change the function's declaration/signature (i.e. the 
>list
>of arguments + return value type). If you think it might be better 
>to
>change the function's signature then just do so a next time.
>
Yes, I rather change function, but I no know if it is OK or not.
I also know about only thinking of *.sta files in that directory.  
I try to do search of *.sta, but it never works for me, so in end, 
I just said "players" directory.
Original for windows did only check *.sta, this also why I left the 
correct me comments, since I no not how to do *.sta when I try.

--
Click for discounts on fashionable Italian charm bracelets
http://tagline.hushmail.com/fc/Ioyw6h4eoPxHojNj5CNsxnoyxCGkVcDvvs55ziBL3JUgUigqQp9gRI/



_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev

Reply via email to