Am Donnerstag, 12. Juli 2007 19:09:14 schrieb Dennis Schridde:
> Am Donnerstag, 12. Juli 2007 18:24:38 schrieb Martin Koller:
> > On Thursday 12 July 2007, Martin Koller wrote:
> > > But what I forgot: we still need my described approach at least for the
> > > audio files to be able to translate them.
> >
> > I attach here a patch which already surrounds now the strings in the .txt
> > files so that I did not have to fiddle with new Makefile rules.
> > Instead the .txt files needed are now also processed via
> >
> > Also I did already a bunch of new german translations for the now much
> > larger de.po file (e.g. most of the texts in the tutorial mission are now
> > translated).
> >
> > I hope I find time to translate (re-record) at least the speech files
> > from the tutorial into german. Please check the text strings if these are
> > OK, so I can then record the speech based on those strings.
> > The patch already includes the previous described search for a <locale>
> > dependant subdir for the translated files and I checked with some test
> > .ogg files if that does what I like and it seems ok.
> >
> > P.S.: I have covered some points Dennis mentioned in my previous
> > translations, but I mainly checked the tutorial, so not all strings are
> > fixed.
> > But this can be done afterwards. I'm sure there will be some other
> > iterations over that file.
> I am afraid your patch to frameresource.c wont work like this.
> - Unconditional inclusion of locale.h, which shouldn't happen when compile
> with --disable-nls, eg. in case where no gettext is available.
> - Variable declaration in the middle of a scope. This will break MSVC.
> - Just curiosity: You cut off everything after '_' in the locale. Is this
> guaranteed to work everywhere?
> - Can the search for the translated file maybe go into an own function? I
> would make it work like gettext(), hand in the filename and get back the
> translation filename in case it exists.
> - setlocale should recieve NULL and delim should be set to '\0'
> - Instead of FILE_MAXCHAR you should use MAX_PATH
> - The locale is the same for all files, so maybe we want to store it
> between retrieving filenames?
> --Dennis

PS: On systems that support it locale.h is included by libintl.h which is 
included by gettext.h which is already included by frame.h.
We also do some fixups for sometimes malfunctioning headers there.
So you should not need to include it yourself.

Attachment: signature.asc
Description: This is a digitally signed message part.

Warzone-dev mailing list

Reply via email to