URL:
<http://gna.org/bugs/?10165>
Summary: Fix for HEAP corruption last reported in bug thread
#10122
Project: Warzone Resurrection Project
Submitted by: None
Submitted on: Tuesday 10/16/2007 at 23:26 CEST
Category: None
Severity: 5 - Blocker
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email: [EMAIL PROTECTED]
Open/Closed: Open
Discussion Lock: Any
Release: svn/trunk
Operating System: Microsoft Windows
Planned Release: None
_______________________________________________________
Details:
Since I am not 100% sure that it is the same bug as in #10122, I will post
fix here.
In Revision: 1979
Author: muggenhor
Date: 9:43:35 AM, Tuesday, June 26, 2007
in multimenu.c was first error in conversion.
It still is present in latest revision 2556.
Issue is null terminating string, but instead the string that is null
terminated is the *filelist*, not *tips*, thus causing crash when physfs
tried to free.
Index: multimenu.c
===================================================================
--- multimenu.c (revision 2556)
+++ multimenu.c (working copy)
@@ -483,7 +483,7 @@
// Copy all of the filename except for the extension into the
tiptext
string
strncpy(tips[tip_index], *currFile, tipStringLength);
// Null terminate the string
- fileList[count][tipStringLength] = '\0';
+ tips[count][tipStringLength] = '\0';
sButInit.pTip = tips[tip_index];
sButInit.pText = tips[tip_index];
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?10165>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev
