Am Montag, 9. Juni 2008 22:53:48 schrieb Giel van Schijndel: > Freddie Witherden schreef: > > Author: evilguru > > Date: Sat Jun 7 23:07:33 2008 > > New Revision: 5232 > > > > URL: http://svn.gna.org/viewcvs/warzone?rev=5232&view=rev > > Log: > > Fix non-debug compilation on OS X > > A non-debug build *should* #define NDEBUG (to shut up the ASSERTs among > others). Hence I think the better fix would be to #define NDEBUG in the > XCode project when producing a non-debug build. I object.
We are: - Defining DEBUG on debug builds and not otherwise. - Defining NDEBUG to shutup asserts. It also seems inconsistent to sometimes decide depending on DEBUG and sometimes depending on NDEBUG, for the same case (as happened here). To prevent such confusion in the first place, I would suggest not using NDEBUG if you mean !DEBUG (or generally not using NDEBUG unless there is a good reason). This is my point of view, Dennis
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
