Per Inge Mathisen schreef:
Here is what I would like to see:
 1) Every patch goes into the patch tracker. Give a quick run down of
what it does and what it changes.
 2) After a patch has been put into the patch tracker, give this list
48 hours to comment on it. Exception for patches that *only* fixes
bugs that makes the game unplayabled or fixes build errors.
I'm not sure if I agree with this or not, it all depends on what your definition of a patch is in this regard.

We are in a state of code quality now that slowing down the commit
rate is a *good* thing. This also makes it easier to work quietly on
bigger patches without them getting broken completely by cleanup work.
Actually, I'm not even sure that I even *want* to see big patches getting done really. I'd much rather see changes being committed as several smaller patches, thus increasing their granularity and making them easier to be understood by others. An (unfortunate?) exception to this would obviously be significant and newly implemented features. Though even in that case I'd prefer a split among several patches (i.e. the unified diff files that represent these changes).

--
Giel

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev

Reply via email to