URL:
  <http://gna.org/bugs/?11976>

                 Summary: Invalid reads in physfs remove search path function
                 Project: Warzone Resurrection Project
            Submitted by: per
            Submitted on: Monday 07/07/2008 at 13:08
                Category: None
                Severity: Important
                Priority: 7 - High
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: svn/trunk
        Operating System: GNU/Linux
         Planned Release: None

    _______________________________________________________

Details:

valgrind reports:

==9340== Invalid read of size 8
==9340==    at 0x4C29C27: freeDirInfo (physfs.c:604)
==9340==    by 0x4C29CF0: PHYSFS_removeFromSearchPath (physfs.c:1006)
==9340==    by 0x485D1D: removeSubdirs (main.c:190)
==9340==    by 0x46BEA9: rebuildSearchPath (init.c:257)
==9340==    by 0x46BDEE: rebuildSearchPath (init.c:240)
==9340==    by 0x48072E: levLoadData (levels.c:676)
==9340==    by 0x486828: startGameLoop (main.c:555)
==9340==    by 0x486BC5: runTitleLoop (main.c:707)
==9340==    by 0x486DEC: mainLoop (main.c:825)
==9340==    by 0x48719B: main (main.c:971)
==9340==  Address 0x11181528 is not stack'd, malloc'd or (recently) free'd
==9340== 
==9340== Invalid read of size 8
==9340==    at 0x4C29C27: freeDirInfo (physfs.c:604)
==9340==    by 0x4C29CF0: PHYSFS_removeFromSearchPath (physfs.c:1006)
==9340==    by 0x46BF52: rebuildSearchPath (init.c:268)
==9340==    by 0x46BDEE: rebuildSearchPath (init.c:240)
==9340==    by 0x48072E: levLoadData (levels.c:676)
==9340==    by 0x486828: startGameLoop (main.c:555)
==9340==    by 0x486BC5: runTitleLoop (main.c:707)
==9340==    by 0x486DEC: mainLoop (main.c:825)
==9340==    by 0x48719B: main (main.c:971)
==9340==  Address 0x11181528 is not stack'd, malloc'd or (recently) free'd
==9340== 
==9340== Invalid read of size 8
==9340==    at 0x4C29C27: freeDirInfo (physfs.c:604)
==9340==    by 0x4C29CF0: PHYSFS_removeFromSearchPath (physfs.c:1006)
==9340==    by 0x46BFC0: rebuildSearchPath (init.c:276)
==9340==    by 0x46BDEE: rebuildSearchPath (init.c:240)
==9340==    by 0x48072E: levLoadData (levels.c:676)
==9340==    by 0x486828: startGameLoop (main.c:555)
==9340==    by 0x486BC5: runTitleLoop (main.c:707)
==9340==    by 0x486DEC: mainLoop (main.c:825)
==9340==    by 0x48719B: main (main.c:971)
==9340==  Address 0x11181528 is not stack'd, malloc'd or (recently) free'd
==9340== 
==9340== Invalid read of size 8
==9340==    at 0x4C29C27: freeDirInfo (physfs.c:604)
==9340==    by 0x4C29CF0: PHYSFS_removeFromSearchPath (physfs.c:1006)
==9340==    by 0x46C3A7: rebuildSearchPath (init.c:354)
==9340==    by 0x46BDEE: rebuildSearchPath (init.c:240)
==9340==    by 0x48072E: levLoadData (levels.c:676)
==9340==    by 0x486828: startGameLoop (main.c:555)
==9340==    by 0x486BC5: runTitleLoop (main.c:707)
==9340==    by 0x486DEC: mainLoop (main.c:825)
==9340==    by 0x48719B: main (main.c:971)
==9340==  Address 0x11181528 is not stack'd, malloc'd or (recently) free'd
==9340== 
==9340== Invalid read of size 8
==9340==    at 0x4C29C27: freeDirInfo (physfs.c:604)
==9340==    by 0x4C29CF0: PHYSFS_removeFromSearchPath (physfs.c:1006)
==9340==    by 0x46C0E0: rebuildSearchPath (init.c:299)
==9340==    by 0x48072E: levLoadData (levels.c:676)
==9340==    by 0x486828: startGameLoop (main.c:555)
==9340==    by 0x486BC5: runTitleLoop (main.c:707)
==9340==    by 0x486DEC: mainLoop (main.c:825)
==9340==    by 0x48719B: main (main.c:971)
==9340==  Address 0x11181528 is not stack'd, malloc'd or (recently) free'd

Checking the return values from the PHYSFS_removeFromSearchPath calls,
indicates a great many bad calls, where the search path is not present. It
seems physfs handles this badly.




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?11976>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Reply via email to