Per Inge Mathisen schreef: > On Sun, Aug 24, 2008 at 4:55 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: >> Author: muggenhor >> Date: Sun Aug 24 16:55:50 2008 >> New Revision: 5864 >> >> URL: http://svn.gna.org/viewcvs/warzone?rev=5864&view=rev >> Log: >> Merged revision r5861 into the 2.1 branch via svnmerge from trunk >> >> ........ >> r5861 | muggenhor | 2008-08-24 14:41:59 +0200 (zo, 24 aug 2008) | 5 lines >> >> * Improve some comments >> * Fix some typos >> * Separate parameters with both a comma and a space, i.e.: ", " >> * Turn a debug(LOG_ERROR for a condition that should never happen into an >> ASSERT > > Why was this backported??
Guess I should have said this in the commit message. "Turn a debug(LOG_ERROR for a condition that should never happen into an ASSERT" is the main reason for backporting that revision. I backported that change because the original comment there basically said that that condition should never occur. I considered that to be a kind of statement that deserves the status of an ASSERTion. To more sufficiently test this ASSERT I backported it to 2.1. Since most distributors use non-debug builds it won't ever fire of the assert() for most binary packages. The rest are just white space & comment changes, which effectively reduce the diff size between trunk & 2.1 making future backporting of code in the same area slightly easier (if they don't break compilation, they won't introduce bugs). -- Giel
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
