On Sun, Feb 28, 2010 at 06:24:23PM -0000, Warzone 2100 Trac wrote: > #1647: Declaration / include cleanup > -------------------------+-------------------------------------------------- > Reporter: cybersphinx | Owner: > Type: to-do | Status: new > Priority: major | Milestone: unspecified > Component: other | Version: svn/trunk > Keywords: | Operating_system: All/Non-Specific > Blockedby: | Blocking: > -------------------------+-------------------------------------------------- > As Cyp recently mentioned, stuff is sometimes declared in several places > (and it's not always the same...). So some cleanup there could be very > helpful. I've attached a patch that does some of this as example. It > mainly touches declarations and includes, though it also removes some > unused variables. > > Any objections to this kind of cleanup?
Cleaning this stuff up is good. Sprinkling the code with declarations like this is an evil practice and while it is quick in the short term, eventually causes maintenance headaches. Anyone doing it now should be spanked. -- Stephen Swaney [email protected] _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
