Hey, guys. In here: http://developer.wz2100.net/ticket/1936
Buggy committed this: > (In [11065]) Fix endian issues, byte & packet counts > for the logging. Info / modifications by Safety0ff & I This commit incremented the netcode version for 2.3-branch. From conversations with Safety0ff, it appears this was unnecessary - netcode compatibility was not broken in that commit. Furthermore, I note that netcode version was incremented without informing ML, tracker, forums, or mentioning it in the commit log, and apparently even Safety0ff didn't know it was done. I only noticed it myself because I was debugging svn/2.3 with some 2.3.1 players. There are two things I want to address in this post. First: I believe that incrementing netcode version in a stable branch is a big thing. I think that incrementing netcode version should always be mentioned in the commit log (no matter which branch), and if done to a stable branch, should be brought up in at least the ML. In addition, patches that break netcode compatibility should note this in the tracker. Can we agree to make this policy? Second: Buggy, is incrementing netcode version necessary? Safety0ff says that none of the changes break netcode compatibility, and that netcode version wasn't incremented in any of the other branches. If not, I'd like to change it back. If so, I have a few other netcode-compatibility-breaking patches I'd like to commit. :P -Zarel _______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
