On Wed, Oct 13, 2010 at 09:59:08AM +0200, Per Inge Mathisen wrote: > I am a little confused by these commit messages. First, why are so > many sent by dak180, even though he is not the committer? Second, I > really really miss the ability to see the diff in trac with a link > from the email. That was so helpful for a quick post-ex-facto code > review. Since we do not have this link, it would be especially > important to have a reference to the change's ticket. And to use the > ticket system to allow code review before making changes. > > Changes like the below trigger my uh-oh filter, but by the time I get > back to my dev box, I will have forgotten about it.
Right, you describe two problems here, first is the mismatch of e-mail "From:" header with the actual committer or author (instead the username of the pusher is used). With SourceForge there's little I know to do about that. Secondly there's the lack of URLs, again with SourceForge there's little I can do about that. I have however expanded the script that fetches from Gitorious to add Trac URLs to new notification e-mails. > On Wed, Oct 13, 2010 at 2:20 AM, dak180 wrote: >> - Log ----------------------------------------------------------------- >> commit 10f2bdede638766ed0ea198d750a00af95fbf110 >> Author: Giel van Schijndel <[email protected]> >> Date: Wed Oct 13 00:10:03 2010 +0200 >> >> scriptfuncs: store (possibly) signed values in signed variables >> >> Store map coordinates in a pair of signed integers as that's how >> map_coord returns them. >> >> Signed-off-by: Giel van Schijndel <[email protected]> >> >> ----------------------------------------------------------------------- >> >> Summary of changes: >> src/scriptfuncs.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) URL for this commit: http://developer.wz2100.net/changeset/10f2bdede638766ed0ea198d750a00af95fbf110 -- Giel -- "In theory, there is no difference between theory and practice. But, in practice, there is." -- Jan L. A. van de Snepscheut
signature.asc
Description: Digital signature
_______________________________________________ Warzone-dev mailing list [email protected] https://mail.gna.org/listinfo/warzone-dev
