#2531: warning fixes and comments for fixes
----------------------------------------+---------------------------
Reporter: antonL@… | Type: bug
Status: new | Priority: normal
Milestone: unspecified | Component: Build system
Version: git/master | Keywords:
Operating System: Windows Vista 64bit | Blocked By:
Blocking: |
----------------------------------------+---------------------------
Dudes, here are some warning fixes.
We don't know how you want us to handle these, the rest are from the
generators you dudes use, flex & bison.
{{{
..\src\multimenu.cpp(1090): warning C4809: switch statement has redundant
'default' label; all possible 'case' labels are given
}}}
{{{
..\src\move.cpp(1991): warning C4146: unary minus operator applied to
unsigned type, result still unsigned
}}}
{{{
..\src\map.cpp(530): warning C4715: 'getTextureType' : not all control
paths return a value
}}}
{{{
\lib\netplay\nettypes.cpp(195): warning C4146: unary minus operator
applied to unsigned type, result still unsigned
..\lib\netplay\nettypes.cpp(271) : see reference to function template
instantiation 'void queue<MessageWriter>(const Q &,int32_t &)' being
compiled
with
[
Q=MessageWriter
]
}}}
{{{
..\lib\netplay\nettypes.cpp(549) : see reference to function template
instantiation 'void queueAuto<int32_t>(T &)' being compiled
with
[
T=int32_t
]
}}}
{{{
..\lib\netplay\nettypes.cpp(199): warning C4146: unary minus operator
applied to unsigned type, result still unsigned
..\lib\netplay\nettypes.cpp(195): warning C4146: unary minus operator
applied to unsigned type, result still unsigned
..\lib\netplay\nettypes.cpp(199): warning C4146: unary minus operator
applied to unsigned type, result still unsigned
..\lib\netplay\nettypes.cpp(275) : see reference to function template
instantiation 'void queue<MessageReader>(const Q &,int32_t &)' being
compiled
with
[
Q=MessageReader
]
}}}
'''needs fixing'''
{{{
..\lib\framework\tagfile.cpp(1198): warning C4805: '==' : unsafe mix of
type 'uint32_t' and type 'bool' in operation
}}}
{{{
..\src\display.cpp(1596): warning C4805: '==' : unsafe mix of type 'UBYTE'
and type 'bool' in operation
..\src\display.cpp(2433): warning C4805: '!=' : unsafe mix of type 'UBYTE'
and type 'bool' in operation
..\src\display.cpp(2446): warning C4805: '!=' : unsafe mix of type 'UBYTE'
and type 'bool' in operation
..\src\display.cpp(2500): warning C4805: '==' : unsafe mix of type 'UBYTE'
and type 'bool' in operation
}}}
{{{
..\src\init.cpp(566): warning C4805: '==' : unsafe mix of type 'UDWORD'
and type 'bool' in operation
}}}
''' How the hell does this routine test audio? There is no sound to test?
'''
{{{
..\lib\sound\audio.cpp(1202): warning C4551: function call missing
argument list
}}}
''' !! '''
{{{
..\src\game.cpp(1288): warning C4806: '==' : unsafe operation: no value of
type 'bool' promoted to type 'int' can equal the given constant
}}}
''' ? '''
{{{
..\src\visibility.cpp(77): warning C4510: 'VisibleObjectHelp_t' : default
constructor could not be generated
..\src\visibility.cpp(68) : see declaration of
'VisibleObjectHelp_t'
..\src\visibility.cpp(77): warning C4610: struct 'VisibleObjectHelp_t' can
never be instantiated - user defined constructor required
}}}
{{{
..\src\raycast.cpp(38): warning C4510: 'HeightCallbackHelp_t' : default
constructor could not be generated
..\src\raycast.cpp(35) : see declaration of
'HeightCallbackHelp_t'
..\src\raycast.cpp(38): warning C4610: struct 'HeightCallbackHelp_t' can
never be instantiated - user defined constructor required
}}}
'''should be fixed'''
{{{
..\lib\netplay\miniupnpc\miniupnpc.c(31): warning C4005: 'strncasecmp' :
macro redefinition
..\lib\framework\wzglobal.h(559) : see previous definition of
'strncasecmp'
..\lib\netplay\miniupnpc\minissdpc.c(64): warning C4996: 'close': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _close. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(74): warning C4996: 'close': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _close. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(79): warning C4996: 'write': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _write. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(83): warning C4996: 'close': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _close. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(86): warning C4996: 'read': The POSIX
name for this item is deprecated. Instead, use the ISO C++ conformant
name: _read. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(90): warning C4996: 'close': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _close. See online help for details.
..\lib\netplay\miniupnpc\minissdpc.c(123): warning C4996: 'close': The
POSIX name for this item is deprecated. Instead, use the ISO C++
conformant name: _close. See online help for details.
}}}
{{{
lib\sequence\sequence.cpp(331): warning C4309: '=' : truncation of
constant value
}}}
{{{
..\src\structure.cpp(547): warning C4245: 'argument' : conversion from
'int' to 'unsigned int', signed/unsigned mismatch
}}}
{{{
..\src\order.cpp(1291): warning C4505: 'orderCheckFireSupportPos' :
unreferenced local function has been removed
}}}
{{{
..\src\multimenu.cpp(1090): warning C4809: switch statement has redundant
'default' label; all possible 'case' labels are given
}}}
{{{
..\src\move.cpp(1991): warning C4146: unary minus operator applied to
unsigned type, result still unsigned
}}}
''' ? '''
{{{
src\map.cpp(530): warning C4715: 'getTextureType' : not all control paths
return a value
}}}
{{{
..\src\feature.cpp(213): warning C4245: '=' : conversion from 'int' to
'UBYTE', signed/unsigned mismatch
}}}
Fix these ?
{{{
..\src\frontend.cpp(489): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(511): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(523): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(535): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(547): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(686): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(690): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(694): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(769): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(781): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(786): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(790): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(962): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(973): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(985): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(998): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1010): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1136): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1152): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1166): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1178): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\frontend.cpp(1181): warning C4245: 'argument' : conversion from
'int' to 'UDWORD', signed/unsigned mismatch
..\src\scriptfuncs.cpp(7469): warning C4245: '=' : conversion from 'int'
to 'UWORD', signed/unsigned mismatch
..\src\scriptfuncs.cpp(7501): warning C4245: '=' : conversion from 'int'
to 'UWORD', signed/unsigned mismatch
}}}
--
Ticket URL: <http://developer.wz2100.net/ticket/2531>
Warzone 2100 Trac <http://developer.wz2100.net/>
The Warzone 2100 Project
_______________________________________________
Warzone-dev mailing list
[email protected]
https://mail.gna.org/listinfo/warzone-dev
