Branch: refs/heads/master
Home: https://github.com/Warzone2100/warzone2100
Commit: ea64e45c0891064350d1ef8ee36b747ef13f1641
https://github.com/Warzone2100/warzone2100/commit/ea64e45c0891064350d1ef8ee36b747ef13f1641
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M CMakeLists.txt
A cmake/CheckCompilerFlagsOutput.cmake
M lib/framework/wzglobal.h
Log Message:
-----------
[CMake] Enable additional compiler warnings
Commit: a98f7dc0aa6d267aad5945d91df03487428f0ccf
https://github.com/Warzone2100/warzone2100/commit/a98f7dc0aa6d267aad5945d91df03487428f0ccf
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/sdl/wz2100icon.h
Log Message:
-----------
Silence MSVC warning C4125: decimal digit terminates octal escape sequence
Commit: c4ca4a9703f298c8853f48d6fb61243059858838
https://github.com/Warzone2100/warzone2100/commit/c4ca4a9703f298c8853f48d6fb61243059858838
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/script/chat_parser.cpp
M lib/script/script_parser.cpp
Log Message:
-----------
Silence MSVC warning `C4702: unreachable code` in the Bison parsers
Commit: 78eb97245ebb3947efa7cf4553a757119e1c0e64
https://github.com/Warzone2100/warzone2100/commit/78eb97245ebb3947efa7cf4553a757119e1c0e64
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/wzstring.cpp
M lib/framework/wzstring.h
M lib/ivis_opengl/screen.cpp
M lib/ivis_opengl/tex.cpp
M lib/ivis_opengl/textdraw.cpp
M lib/script/eventsave.cpp
M lib/widget/tip.cpp
M src/frontend.cpp
M src/game.cpp
M src/message.cpp
M src/multigifts.cpp
M src/qtscript.cpp
M src/research.cpp
M src/structure.cpp
Log Message:
-----------
Fix some `warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]`
Commit: 163ce4c15d665a1ad4a34fba43dbc602bf8665bc
https://github.com/Warzone2100/warzone2100/commit/163ce4c15d665a1ad4a34fba43dbc602bf8665bc
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/multiplay.cpp
Log Message:
-----------
Silence MSVC warning C4244: 'argument': conversion from 'PHYSFS_sint64' to
'uint32_t', possible loss of data
Commit: c6da58b863d6bc37589e12bfcc284f12fb0e80d6
https://github.com/Warzone2100/warzone2100/commit/c6da58b863d6bc37589e12bfcc284f12fb0e80d6
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/resource_lexer.cpp
M lib/framework/strres_lexer.cpp
M src/level_lexer.cpp
M src/scriptvals_lexer.cpp
Log Message:
-----------
Silence MSVC warning C4003: not enough actual parameters for macro
'identifier'
Commit: 53bb66ae9c1c0105969c87a6d7025d2637f785b4
https://github.com/Warzone2100/warzone2100/commit/53bb66ae9c1c0105969c87a6d7025d2637f785b4
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/script/chat_parser.cpp
M lib/script/script_parser.cpp
M src/scriptvals_parser.cpp
Log Message:
-----------
Silence MSVC warning C4065: switch statement contains 'default' but no 'case'
labels
Commit: 5b51650e2bd3fd88b71694d0a84fd23105394865
https://github.com/Warzone2100/warzone2100/commit/5b51650e2bd3fd88b71694d0a84fd23105394865
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/scriptfuncs.cpp
Log Message:
-----------
Fix MSVC warning C4805: '==': unsafe mix of type 'int32_t' and type 'bool' in
operation
Commit: b2866ab8462a1b84e0decd85134cc42822b68de2
https://github.com/Warzone2100/warzone2100/commit/b2866ab8462a1b84e0decd85134cc42822b68de2
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/netplay.cpp
Log Message:
-----------
Fix MSVC warning C4805: '!=': unsafe mix of type 'uint32_t' and type 'bool'
in operation
Commit: e5c2a18298a083fbbd9bdcae468b1bb0eafb3d31
https://github.com/Warzone2100/warzone2100/commit/e5c2a18298a083fbbd9bdcae468b1bb0eafb3d31
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/exceptionhandler/exceptionhandler.cpp
M src/main.cpp
Log Message:
-----------
Silence MSVC warning when building with the Windows 7 SDK
The Windows SDK headers can trigger the following warning when building with
MSVC 2015 / 2017 and the "XP" toolchain (which uses the much older Windows 7
SDK):
```
microsoft sdks\windows\v7.1a\include\shlobj.h(1151): warning C4091: 'typedef ':
ignored on left of 'tagGPFIDL_FLAGS' when no variable is declared
```
Commit: dbd22a3f95ba2aff426f708939f4656111668d53
https://github.com/Warzone2100/warzone2100/commit/dbd22a3f95ba2aff426f708939f4656111668d53
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/nettypes.cpp
M src/bucket3d.cpp
M src/display3d.cpp
M src/projectile.cpp
M src/wavecast.cpp
Log Message:
-----------
Silence MSVC warning C4146: unary minus operator applied to unsigned type,
result still unsigned
Commit: 506cf1e316173a2b4d4ecc3b79acc84e66d2a210
https://github.com/Warzone2100/warzone2100/commit/506cf1e316173a2b4d4ecc3b79acc84e66d2a210
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/keybind.cpp
M src/map.h
M src/multiint.cpp
M src/scriptfuncs.cpp
M src/wavecast.cpp
Log Message:
-----------
Fix MSVC warning C4701: potentially uninitialized local variable 'name' used
Commit: f8c36bdab5800e0d16693c1f444259d1bbd6d73e
https://github.com/Warzone2100/warzone2100/commit/f8c36bdab5800e0d16693c1f444259d1bbd6d73e
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/nettypes.cpp
M src/template.cpp
M src/visibility.cpp
M src/wavecast.h
Log Message:
-----------
Fix MSVC warning C4267: conversion from 'size_t' to 'type', possible loss of
data
Commit: 1af65c7429e13118c7a39f45b37f65fa36e8aae9
https://github.com/Warzone2100/warzone2100/commit/1af65c7429e13118c7a39f45b37f65fa36e8aae9
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
A docker/ubuntu-18.04-clang/Dockerfile
Log Message:
-----------
Add Ubuntu 18.04 Clang Dockerfile
Commit: e61a04e227b0276ac557619e3a25126914476867
https://github.com/Warzone2100/warzone2100/commit/e61a04e227b0276ac557619e3a25126914476867
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M .travis.yml
Log Message:
-----------
[Travis CI] Add test build on Ubuntu 18.04 (Clang, CMake)
Commit: 27884eab9954aa313ed70b516e81613f3b5d49dc
https://github.com/Warzone2100/warzone2100/commit/27884eab9954aa313ed70b516e81613f3b5d49dc
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/CMakeLists.txt
Log Message:
-----------
[CMake] Find Thread library for lib/netplay
Commit: 89c9aedd457486615b368c71c22b4dd30b4e966f
https://github.com/Warzone2100/warzone2100/commit/89c9aedd457486615b368c71c22b4dd30b4e966f
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/piedraw.cpp
M src/terrain.cpp
Log Message:
-----------
Fix -Wnull-pointer-arithmetic warnings
Example:
```
/src/terrain.cpp:147:23: warning: arithmetic on a null pointer treated as a
cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
BUFFER_OFFSET(sizeof(GLuint)*dreOffset));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/src/terrain.cpp:127:40: note: expanded from macro 'BUFFER_OFFSET'
#define BUFFER_OFFSET(i) ((char *)NULL + (i))
```
Commit: bbd56bf0a4f28b2c694815a9a5709a2d54645ca3
https://github.com/Warzone2100/warzone2100/commit/bbd56bf0a4f28b2c694815a9a5709a2d54645ca3
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/resource_lexer.cpp
M lib/framework/strres_lexer.cpp
M lib/gamelib/audp_lexer.cpp
M lib/script/chat_lexer.cpp
M lib/script/script_lexer.cpp
M src/level_lexer.cpp
M src/scriptvals_lexer.cpp
Log Message:
-----------
Silence -Wunneeded-internal-declaration warnings in the flex scanners
Commit: 84cb3fa5aa5a3475b9c659a3b52d91d3ed72d3e6
https://github.com/Warzone2100/warzone2100/commit/84cb3fa5aa5a3475b9c659a3b52d91d3ed72d3e6
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/qtscriptfuncs.cpp
Log Message:
-----------
Fix -Wduplicated-cond warning
Warning was:
```
../src/qtscriptfuncs.cpp: In function 'void showLabel(const QString&, bool,
bool)':
../src/qtscriptfuncs.cpp:328:7: warning: duplicated 'if' condition
[-Wduplicated-cond]
else if (l.type == SCRIPT_RADIUS)
^~
../src/qtscriptfuncs.cpp:310:18: note: previously used here
else if (l.type == SCRIPT_RADIUS)
~~~~~~~^~~~~~~~~~~~~~~~
```
Commit: 4d98e76a486412feeecb40bca1feb8233ea4ad66
https://github.com/Warzone2100/warzone2100/commit/4d98e76a486412feeecb40bca1feb8233ea4ad66
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/multimenu.cpp
M src/structure.cpp
Log Message:
-----------
Fix MSVC warning C4457: declaration of 'identifier' hides function parameter
Commit: 8a35669bf7ddfee574d91c79ddd72d7e41e5d710
https://github.com/Warzone2100/warzone2100/commit/8a35669bf7ddfee574d91c79ddd72d7e41e5d710
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/widget/button.cpp
M lib/widget/button.h
M lib/widget/listwidget.cpp
M lib/widget/listwidget.h
M src/droid.cpp
M src/visibility.cpp
Log Message:
-----------
Fix MSVC warning C4458: declaration of 'identifier' hides class member
Commit: 71a778dc4a7e57c54655a8015b3b3c3b417c261c
https://github.com/Warzone2100/warzone2100/commit/71a778dc4a7e57c54655a8015b3b3c3b417c261c
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/exceptionhandler/3rdparty/StackWalker.h
Log Message:
-----------
[Windows] StackWalker: Always use RtlCaptureContext (when possible)
Commit: b0b03fe18e643be7903dee4b85f3a14c1e0c0afc
https://github.com/Warzone2100/warzone2100/commit/b0b03fe18e643be7903dee4b85f3a14c1e0c0afc
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/wzconfig.cpp
Log Message:
-----------
Fix MSVC warning C4244: '=': conversion from 'int' to 'char', possible loss
of data
Warning was:
```
lib\framework\wzconfig.cpp(623): note: see reference to function template
instantiation '_OutIt
std::transform<std::_String_iterator<std::_String_val<std::_Simple_types<_Ty>>>,std::_String_iterator<std::_String_val<std::_Simple_types<_Ty>>>,int(__cdecl
*)(int)>(const _InIt,const _InIt,_OutIt,_Fn)' being compiled
with
[
_OutIt=std::_String_iterator<std::_String_val<std::_Simple_types<char>>>,
_Ty=char,
_InIt=std::_String_iterator<std::_String_val<std::_Simple_types<char>>>,
_Fn=int (__cdecl *)(int)
]
```
Commit: 2e63bd0d797d7b7302c5e639d40ff68eebd030b7
https://github.com/Warzone2100/warzone2100/commit/2e63bd0d797d7b7302c5e639d40ff68eebd030b7
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/imdload.cpp
Log Message:
-----------
Fix MSVC warning C4244: 'initializing': conversion from 'int' to 'unsigned
short', possible loss of data
Commit: e7e712573e1fdb098eab754e62e1761d62f9e0fb
https://github.com/Warzone2100/warzone2100/commit/e7e712573e1fdb098eab754e62e1761d62f9e0fb
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/jpeg_encoder.cpp
Log Message:
-----------
Fix MSVC warning C4244: '=': conversion from 'UINT32' to 'UINT16', possible
loss of data
Warnings were:
```
lib\ivis_opengl\jpeg_encoder.cpp(882): warning C4244: '=': conversion from
'UINT32' to 'UINT16', possible loss of data
lib\ivis_opengl\jpeg_encoder.cpp(898): warning C4244: '=': conversion from
'UINT32' to 'UINT16', possible loss of data
```
Commit: a43cbb6b30267aa74d1bdb93e24aaa8aa98551ab
https://github.com/Warzone2100/warzone2100/commit/a43cbb6b30267aa74d1bdb93e24aaa8aa98551ab
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/netplay.cpp
M src/multiint.cpp
Log Message:
-----------
Fix some -Wformat-security warnings
Commit: f003d795935bcf11c8fa55d2e1ecec79251f74db
https://github.com/Warzone2100/warzone2100/commit/f003d795935bcf11c8fa55d2e1ecec79251f74db
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/utf.cpp
M lib/framework/utf.h
M lib/netplay/netsocket.cpp
M lib/sound/openal_error.cpp
M src/game.cpp
M src/game.h
M src/multiint.cpp
M src/oprint.cpp
M src/scriptfuncs.cpp
M src/stats.cpp
M src/structure.cpp
M src/transporter.cpp
M src/visibility.h
Log Message:
-----------
Fix `drops const qualifier [-Wcast-qual]` warnings
Commit: fabda2e7e58b3a1d9476a85bbd35b14af666fea3
https://github.com/Warzone2100/warzone2100/commit/fabda2e7e58b3a1d9476a85bbd35b14af666fea3
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/sound/aud.h
M src/aud.cpp
M src/droid.cpp
M src/droid.h
M src/structure.cpp
M src/structure.h
M src/visibility.cpp
Log Message:
-----------
Add missing const qualifiers
Also fixes more `drops const qualifier [-Wcast-qual]` warnings in visibility.cpp
Commit: a55384ee938ff59744b2a98ff05542df493deb72
https://github.com/Warzone2100/warzone2100/commit/a55384ee938ff59744b2a98ff05542df493deb72
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/cheat.cpp
M src/display3d.cpp
M src/hci.cpp
M src/keybind.cpp
Log Message:
-----------
Fix `drops const qualifier [-Wcast-qual]` warnings when calling `sasprintf`
Commit: fb3ffd986315f5ab210d7f9db7ddadb1720edf16
https://github.com/Warzone2100/warzone2100/commit/fb3ffd986315f5ab210d7f9db7ddadb1720edf16
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/gettext.h
M lib/framework/i18n.h
Log Message:
-----------
Fix gettext.h warning: ISO C++ forbids variable length array 'msg_ctxt_id'
[-Wvla]
Commit: e59820a4d7020b16bdf9dba9d1e764616b6d47ab
https://github.com/Warzone2100/warzone2100/commit/e59820a4d7020b16bdf9dba9d1e764616b6d47ab
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/netsocket.cpp
Log Message:
-----------
Fix netsocket.cpp debug statement typo
The socket, in this context, is actually `sock`.
Commit: 2c623d912e87d868287eb0ba2fd825aa7e84ead6
https://github.com/Warzone2100/warzone2100/commit/2c623d912e87d868287eb0ba2fd825aa7e84ead6
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/netplay/netplay.cpp
M lib/netplay/netsocket.cpp
M lib/script/interpreter.cpp
M lib/sound/audio.cpp
M lib/sound/cdaudio.cpp
M lib/sound/openal_track.cpp
M src/droid.cpp
M src/feature.cpp
M src/levels.cpp
M src/objmem.cpp
M src/oprint.cpp
M src/qtscriptfuncs.cpp
M src/research.cpp
M src/scriptai.cpp
M src/scriptfuncs.cpp
M src/scriptobj.cpp
M src/scriptvals.cpp
M src/structure.cpp
M src/visibility.cpp
Log Message:
-----------
Fix warning: format specifies type 'void *' but the argument has type
'identifier' [-Wformat-pedantic]
Commit: 3f4272f30f3bc5ad3384c205a82f9bcab8ae670a
https://github.com/Warzone2100/warzone2100/commit/3f4272f30f3bc5ad3384c205a82f9bcab8ae670a
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/intorder.cpp
Log Message:
-----------
Fix intorder.cpp `[-Wpedantic]` warning
Warning was:
```
../src/intorder.cpp:178:2: warning: extra ';' [-Wpedantic]
};
^
```
Commit: 657d4ca398e9b1eeee57dc87044100bb5fa712f4
https://github.com/Warzone2100/warzone2100/commit/657d4ca398e9b1eeee57dc87044100bb5fa712f4
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/exceptionhandler/3rdparty/StackWalker.cpp
M lib/netplay/netsocket.cpp
Log Message:
-----------
Fix MSVC warning C4191: 'type cast': unsafe conversion from 'FARPROC' to
'type required'
Warnings were:
```
lib\netplay\netsocket.cpp(1465): warning C4191: 'type cast': unsafe conversion
from 'FARPROC' to 'GETADDRINFO_DLL_FUNC'
lib\netplay\netsocket.cpp(1466): warning C4191: 'type cast': unsafe conversion
from 'FARPROC' to 'FREEADDRINFO_DLL_FUNC'
```
And numerous similar warnings in StackWalker.cpp
Commit: f1bcef8ccb036a1eba521e6b0b30625fc50663f0
https://github.com/Warzone2100/warzone2100/commit/f1bcef8ccb036a1eba521e6b0b30625fc50663f0
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/imdload.cpp
M src/clparse.cpp
M src/message.cpp
Log Message:
-----------
Fix `[-Wformat=]` warnings
Warnings were:
```
../lib/ivis_opengl/imdload.cpp:978:58: warning: format '%d' expects argument of
type 'int*', but argument 4 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/clparse.cpp:559:47: warning: format '%i' expects argument of type
'int*', but argument 3 has type 'unsigned int*' [-Wformat=]
../src/clparse.cpp:559:47: warning: format '%i' expects argument of type
'int*', but argument 4 has type 'unsigned int*' [-Wformat=]
../src/message.cpp:480:66: warning: format '%d' expects argument of type
'int*', but argument 4 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/message.cpp:515:61: warning: format '%d' expects argument of type
'int*', but argument 7 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/message.cpp:555:46: warning: format '%d' expects argument of type
'int*', but argument 3 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/message.cpp:569:68: warning: format '%d' expects argument of type
'int*', but argument 4 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/message.cpp:578:80: warning: format '%d' expects argument of type
'int*', but argument 4 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
../src/message.cpp:599:72: warning: format '%d' expects argument of type
'int*', but argument 4 has type 'UDWORD* {aka unsigned int*}' [-Wformat=]
```
Commit: ca470408d95eccbd0491399ae1b6a13a495b333a
https://github.com/Warzone2100/warzone2100/commit/ca470408d95eccbd0491399ae1b6a13a495b333a
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/screen.cpp
Log Message:
-----------
Fix MSVC warning C4191: 'type cast': unsafe conversion from 'void (__cdecl
*)(...)' to 'GLDEBUGPROC'
Warning was:
```
lib\ivis_opengl\screen.cpp(335): warning C4191: 'type cast': unsafe conversion
from 'void (__cdecl *)(GLenum,GLenum,GLuint,GLenum,GLsizei,const GLchar *,const
void *)' to 'GLDEBUGPROC'
```
The definition of `khr_callback` was missing GLAPIENTRY (to specify the calling
convention on Windows).
Commit: 8ad68515b8b0bbf073a804478882381514acaa8a
https://github.com/Warzone2100/warzone2100/commit/8ad68515b8b0bbf073a804478882381514acaa8a
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/exceptionhandler/dumpinfo.cpp
M lib/exceptionhandler/dumpinfo.h
M lib/exceptionhandler/exceptionhandler.cpp
M lib/exceptionhandler/exceptionhandler.h
M src/clparse.cpp
M src/clparse.h
M src/main.cpp
Log Message:
-----------
Fix `cast from 'char **' to 'const char **' must have all intermediate
pointers const qualified to be safe [-Wcast-qual]`
Warning was:
```
../src/main.cpp:1071:40: warning: cast from 'char **' to 'const char **' must
have all intermediate pointers const qualified to be safe [-Wcast-qual]
const char **utfargv = (const char **)argv;
```
Commit: 600d8a57d8158eabeb42b4a1e8379de8bc02b50c
https://github.com/Warzone2100/warzone2100/commit/600d8a57d8158eabeb42b4a1e8379de8bc02b50c
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/sound/audio.cpp
M lib/sound/audio.h
M lib/sound/cdaudio.cpp
M lib/sound/openal_track.cpp
M lib/sound/track.h
M lib/sound/tracklib.h
M src/intelmap.cpp
Log Message:
-----------
Fix `drops const qualifier [-Wcast-qual]` warnings in lib/sound
Warning example:
```
../lib/sound/cdaudio.cpp:94:95: warning: cast from 'const char *' to 'char *'
drops const qualifier [-Wcast-qual]
cdStream = sound_PlayStreamWithBuf(music_file, music_volume,
cdAudio_TrackFinished, (char *)filename, bufferSize, buffer_count);
```
Commit: 68e39fdc7472cf833a257fea3805259139e587e7
https://github.com/Warzone2100/warzone2100/commit/68e39fdc7472cf833a257fea3805259139e587e7
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/scriptfuncs.cpp
Log Message:
-----------
Silence `drops const qualifier [-Wcast-qual]` warnings in scriptfuncs.cpp
Commit: 169120bf45b749a2145844e74eaec1c921d77691
https://github.com/Warzone2100/warzone2100/commit/169120bf45b749a2145844e74eaec1c921d77691
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/debug.cpp
M src/clparse.cpp
M src/main.cpp
Log Message:
-----------
Fix clparse.cpp GCC warning: `cast from type 'const char*' to type 'void*'
casts away qualifiers [-Wcast-qual]`
Warning was:
```
../src/clparse.cpp:378:109: warning: cast from type 'const char*' to type
'void*' casts away qualifiers [-Wcast-qual]
debug_register_callback(debug_callback_file, debug_callback_file_init,
debug_callback_file_exit, (void *)token);
```
Commit: 6baa57d975101165394684bad2c621a68e706b31
https://github.com/Warzone2100/warzone2100/commit/6baa57d975101165394684bad2c621a68e706b31
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/debug.cpp
Log Message:
-----------
[Windows] Fix Unicode log path support
On Windows, path strings passed to `fopen()` are interpreted using the ANSI or
OEM codepage (and not as UTF-8). To support Unicode paths, the string must be
converted to a wide-char string and passed to `_wfopen`.
Commit: 6f327bf28de9e79c45688b3a9d5917f892a87d2a
https://github.com/Warzone2100/warzone2100/commit/6f327bf28de9e79c45688b3a9d5917f892a87d2a
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/data.cpp
M src/message.cpp
M src/message.h
Log Message:
-----------
Fix data.cpp GCC warnings: `cast from type 'const char*' to type 'void*'
casts away qualifiers [-Wcast-qual]`
Warnings were:
```
../src/data.cpp: In function 'bool bufferSMSGLoad(const char*, UDWORD, void**)':
../src/data.cpp:429:20: warning: cast from type 'const char*' to type 'void*'
casts away qualifiers [-Wcast-qual]
*ppData = (void *)ptr;
../src/data.cpp: In function 'bool dataResearchMsgLoad(const char*, void**)':
../src/data.cpp:443:20: warning: cast from type 'const char*' to type 'void*'
casts away qualifiers [-Wcast-qual]
*ppData = (void *)ptr;
```
Commit: e17b8a6c7b45813556d956d6e586fcae0e93af61
https://github.com/Warzone2100/warzone2100/commit/e17b8a6c7b45813556d956d6e586fcae0e93af61
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/sdl/main_sdl.cpp
Log Message:
-----------
Silence main_sdl.cpp GCC `[-Wcast-qual]` warning
Warning was:
```
../lib/sdl/main_sdl.cpp:1939:74: warning: cast from type 'const unsigned char*'
to type 'void*' casts away qualifiers [-Wcast-qual]
SDL_Surface *surface_icon = SDL_CreateRGBSurfaceFrom((void
*)wz2100icon.pixel_data, wz2100icon.width, wz2100icon.height,
wz2100icon.bytes_per_pixel * 8,
```
Commit: d907e14411478ad473d36af50b53ed5da666da42
https://github.com/Warzone2100/warzone2100/commit/d907e14411478ad473d36af50b53ed5da666da42
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/multiplay.cpp
Log Message:
-----------
Fix `drops const qualifier [-Wcast-qual]` warnings in multiplay.cpp
Warnings were:
```
../src/multiplay.cpp:1216:28: warning: cast from 'const char *' to 'char *'
drops const qualifier [-Wcast-qual]
char *curStr = (char *)pStr;
^
../src/multiplay.cpp:1454:20: warning: cast from 'const char *' to 'char *'
drops const qualifier [-Wcast-qual]
NETstring((char *)pStr, MAX_CONSOLE_STRING_LENGTH); // copy message in.
```
Commit: 2443b12659920ba8e4dfb6356f96ab4b2fb0f6da
https://github.com/Warzone2100/warzone2100/commit/2443b12659920ba8e4dfb6356f96ab4b2fb0f6da
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/ivis_opengl/png_util.cpp
Log Message:
-----------
Silence MSVC warning C4611: interaction between '_setjmp' and C++ object
destruction is non-portable
Commit: 4e1bf292234d8dcaa4900ea180a351c6b655db71
https://github.com/Warzone2100/warzone2100/commit/4e1bf292234d8dcaa4900ea180a351c6b655db71
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M lib/framework/resource_lexer.cpp
M lib/framework/strres_lexer.cpp
M lib/gamelib/audp_lexer.cpp
M lib/script/chat_lexer.cpp
M lib/script/parse.h
M lib/script/script_lexer.cpp
M lib/script/script_parser.cpp
M src/level_lexer.cpp
M src/scriptvals_lexer.cpp
Log Message:
-----------
Fix `could be declared with attribute 'noreturn' [-Wmissing-noreturn]`
warnings
Commit: 57e1d38529ed0bf025c2c1c612284354dfe8f8d2
https://github.com/Warzone2100/warzone2100/commit/57e1d38529ed0bf025c2c1c612284354dfe8f8d2
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/game.cpp
M src/stats.cpp
M src/stats.h
M src/statsdef.h
M src/structure.cpp
M src/template.cpp
M src/template.h
Log Message:
-----------
Fix various signed/unsigned mismatch (and other conversion / comparison
issues) related to templates
Commit: 441ead36b08115e91285d90aeded1a6bcbbde9ee
https://github.com/Warzone2100/warzone2100/commit/441ead36b08115e91285d90aeded1a6bcbbde9ee
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/template.cpp
Log Message:
-----------
Fix MSVC warning C4244: '=': conversion from 'const int' to 'uint8_t',
possible loss of data
Commit: a4942a2571a39164f7151776c359e2b54e7f0415
https://github.com/Warzone2100/warzone2100/commit/a4942a2571a39164f7151776c359e2b54e7f0415
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M src/configuration.cpp
Log Message:
-----------
Fix MSVC warning C4305: '=': truncation from 'int' to 'bool'
Commit: 9b424de642f5fb446026923d231c6103539fdffb
https://github.com/Warzone2100/warzone2100/commit/9b424de642f5fb446026923d231c6103539fdffb
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
[CMake] Add option to treat warnings as errors
Commit: 59e98f2cc9db43e98d6bbf8373711366a9846ea0
https://github.com/Warzone2100/warzone2100/commit/59e98f2cc9db43e98d6bbf8373711366a9846ea0
Author: past-due <[email protected]>
Date: 2018-07-08 (Sun, 08 Jul 2018)
Changed paths:
M CMakeLists.txt
Log Message:
-----------
[CMake] Warning tweaks for GCC 8.0 (matching configure.ac)
Compare:
https://github.com/Warzone2100/warzone2100/compare/2e991acc6779...59e98f2cc9db
**NOTE:** This service been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Warzone2100-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/warzone2100-commits
