#4612: Fix allocation of players, spelling corrections and fewer LOC
-------------------------------------------------+-------------------------
Reporter: Forgon | Owner:
Type: patch (an actual patch, not | Status: new
a request for one) | Milestone: unspecified
Priority: normal | Version: git/master
Component: other |
Operating System: All/Non-Specific |
-------------------------------------------------+-------------------------
The function 'processDebugMappings()' in './src/keymap.cpp' activates the
debug mode if Player 0 is
not allocated at its invocation. This lead to two errors in the bizarre
code responsible for loading games, both of which are now patched:
- skirmish savegames loaded from within skirmish games start in DEBUG mode
(see './src/game.cpp')
- games launched with '--game' start in DEBUG mode. In all modes except
TUTORIAL3, the player cannot move units with a left click after selecting
them as in the cheat 'autogame on' (see './src/clparse.cpp')
Other changes:
- 'keyClearMappings' in './src/keymap.cpp' was a useless function and
called both before and during the start of 'keyInitMappings' in several
instances (see './src/init.cpp', './src/keyedit.cpp', './src/keymap.cpp')
- chat messages in campaigns and tutorials now display 'Commander' as
player name (see './src/multiplay.cpp')
- no more empty line at the start of logfiles (see
'./lib/framework/debug.cpp')
- no more two consecutive slashes in pathnames (hopefully) (see
'./lib/framework/frame.cpp' and './src/levels.cpp')
- removed unused and empty functions 'StartTextInput()' and
'StopTextInput' (see './lib/qtgame/main_qt.cpp')
- fixed typos: allign -> align, allignment -> alignment, blu box -> blue
box, bluboxes -> blue boxes, initalised -> initialised, initalise ->
initialise, seperated -> separated, seperate -> separate, seperator ->
separator
--
Ticket URL: <http://developer.wz2100.net/ticket/4612>
Warzone 2100 Trac <http://developer.wz2100.net/>
The Warzone 2100 Project
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Warzone2100-project mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/warzone2100-project
