Hi Navi — the version there refers to Watir Screenshot Stitch. When we publish version 0.7.0, we will no longer allow you to pass the browser in. This was a hack that we needed, but thanks to the changes Titus has made to Watir, the Screenshot class now knows the browser it was created for.
Sorry that wasn’t clear! -Sam > On Sep 21, 2018, at 11:37 AM, NaviHan <[email protected]> wrote: > > Hi Sam > > Just found this warning > 2018-09-21 20:32:17 WARN Watir Screenshot Stitch [DEPRECATION] Passing the > browser is deprecated and will no longer work in version 0.7.0 > /lib/watir-screenshot-stitch.rb:31 > > > In fact I did try using version 0.7.0 of ImageMagick, but found this issue > mentioned in this thread (issue with convert command) --> > https://stackoverflow.com/questions/38163849/imagemagick-issue-with-windows-and-convert-function > > So I reverted to 6.9 > > But aren't we supposed to pass browser as mentioned in the previous reply? > > Cheers > Navi > > On Thursday, 20 September 2018 21:14:17 UTC+10, NaviHan wrote: > Hi > > I have put this code in the hooks which takes scresnshot when a test fails. > The issue is that Im not getting the full browser screen. Its chops off at > the bottom > > After do |scenario| > take_screenshot(@browser, scenario) > end > > > def take_screenshot(browser, scenario) > time = Time.now.strftime("%Y-%m-%d_%H%M") > if scenario.failed? > scenario_name = scenario.name.gsub(/[^\w\-]/, ' ') > screenshot_path = "#{scenario_name}" + "_failure_" + time > @browser.screenshot.save("./screenshots/#{screenshot_path}.png") > end > end > > By the way my before hooks looks like this. > > Before do|scenario| > ENV['HTTP_PROXY'] = ENV['http_proxy'] = nil > @browser.goto "https://www.sandbox.paypal.com > <https://www.sandbox.paypal.com/>" > @browser.cookies.clear > @browser.goto "https://portal-sandbox.afterpay.com > <https://portal-sandbox.afterpay.com/>" > @browser.cookies.clear > @browser.goto "https://i-pay.co.za <https://i-pay.co.za/>" > @browser.cookies.clear > @browser.goto("ci.XXX.com/ <http://ci.xxx.com/>") > @browser.window.maximize > @browser.driver.manage.timeouts.implicit_wait = 0 > @browser.cookies.clear > @browser.driver.manage.window.maximize > PageObject.default_element_wait=(10) > PageObject.javascript_framework = :jquery > end #before scenario > > > > -- > -- > Before posting, please read > https://github.com/watir/watir_meta/wiki/Guidelines-for-Posting-to-Watir-General-Google-Group > > <https://github.com/watir/watir_meta/wiki/Guidelines-for-Posting-to-Watir-General-Google-Group>. > In short: search before you ask, be nice. > > [email protected] > http://groups.google.com/group/watir-general > <http://groups.google.com/group/watir-general> > [email protected] > --- > You received this message because you are subscribed to a topic in the Google > Groups "Watir General" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/watir-general/Cp8TbjnWpn8/unsubscribe > <https://groups.google.com/d/topic/watir-general/Cp8TbjnWpn8/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- -- Before posting, please read https://github.com/watir/watir_meta/wiki/Guidelines-for-Posting-to-Watir-General-Google-Group. In short: search before you ask, be nice. [email protected] http://groups.google.com/group/watir-general [email protected] --- You received this message because you are subscribed to the Google Groups "Watir General" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Message signed with OpenPGP
