[
https://issues.apache.org/jira/browse/WAVE-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034190#comment-13034190
]
Yuri Zelikov commented on WAVE-273:
-----------------------------------
Talking about hard coded values in BlipMeaViewBuilder - then the title of the
avatar image is also hard coded to be "author" instead of represent the actual
author name/address.
// Author avatar.
image(output, Components.AVATAR.getDomId(id), css.avatar(),
EscapeUtils.fromString(avatarUrl),
EscapeUtils.fromPlainText("author"), null);
> BlipMetaViewBuilder uses a hard coded kind for the Blip Contents
> ----------------------------------------------------------------
>
> Key: WAVE-273
> URL: https://issues.apache.org/jira/browse/WAVE-273
> Project: Wave
> Issue Type: Task
> Components: Web Client
> Reporter: Michael MacFadden
>
> The BlipMetaViewBuilder's outputHtml(...) method has the following code
> snippet:
> open(output, Components.CONTENT.getDomId(id), css.contentContainer(),
> "document");
> This results in the following HTML (or something similar):
> <div id="UC2MC" class="SWCNN" kind="document">
> As can be seen the kind attribute is set to "document", and is hard coded in
> the builders code. In the other builders we use something along the lines of
> "TypeCodes.kind(Type.BLIP)" for the kind attribute. BlipMetaViewBuilder hard
> coded kind should be cleaned up to follow the convention, if a kind is in
> fact needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
