[
https://issues.apache.org/jira/browse/WAVE-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157426#comment-13157426
]
[email protected] commented on WAVE-298:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2932/#review3515
-----------------------------------------------------------
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7852>
The line is too long - longer than 100 chars which is the standard for WIAB.
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7859>
Line is too long.
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7856>
Seems like the <code></code> tags here are not needed,{@link} already
formats it.
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7854>
No need to specify that methods solve issue.
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7855>
Probably it would be better just to remove @param and @return since they
add no details.
/test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java
<https://reviews.apache.org/r/2932/#comment7849>
How about returning the Collections.EmptyMap() here?
I mean:
Map<String, String[]> emptyMap = Collections.emptyMap();
when(req.getParameterMap()).thenReturn(emptyMap);
- Yuri
On 2011-11-25 18:23:15, Antonio Bello wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2932/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-25 18:23:15)
bq.
bq.
bq. Review request for wave.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch solves the problem in my case.
bq.
bq. I'm running ubuntu x64, and experienced the same problem.
bq.
bq. What I did is simply change the parameter type passed to the thenReturn()
method:
bq. * convert StringTokenizer to Enumeration<String> in ActiveApiServletTest
bq. * replace ImmutableMap.of() with new Hashtable<String, String[]>() in
DataApiServletTest
bq.
bq.
bq. This addresses bug WAVE-298.
bq. https://issues.apache.org/jira/browse/WAVE-298
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java
1206126
bq. /test/org/waveprotocol/box/server/robots/dataapi/DataApiServletTest.java
1206126
bq.
bq. Diff: https://reviews.apache.org/r/2932/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ant test runs with no errors on ubuntu x64 10.04
bq.
bq.
bq. Thanks,
bq.
bq. Antonio
bq.
bq.
> Wave doesn't compile: error: no suitable method found for
> thenReturn(StringTokenizer)
> --------------------------------------------------------------------------------------
>
> Key: WAVE-298
> URL: https://issues.apache.org/jira/browse/WAVE-298
> Project: Wave
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.1
> Environment: Tested on Debian/unstable with Java 6 and Java 7, and on
> Ubuntu 11.10.
> Reporter: Thomas Leonard
> Assignee: Yuri Zelikov
> Attachments: patch-wave-298.txt
>
>
> $ ant
> [...]
> compile-tests:
> [javac] Compiling 380 source files to /home/tal/src/wave/build/test
> [javac]
> /home/tal/src/wave/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java:99:
> error: no suitable method found for thenReturn(StringTokenizer)
> [javac] when(req.getHeaderNames()).thenReturn(new
> StringTokenizer("Authorization"));
> [javac] ^
> [javac] method OngoingStubbing.thenReturn(Enumeration<String>) is not
> applicable
> [javac] (actual argument StringTokenizer cannot be converted to
> Enumeration<String> by method invocation conversion)
> [javac] method
> OngoingStubbing.thenReturn(Enumeration<String>,Enumeration<String>...) is not
> applicable
> [javac] (actual argument StringTokenizer cannot be converted to
> Enumeration<String> by method invocation conversion)
> [javac]
> /home/tal/src/wave/test/org/waveprotocol/box/server/robots/active/ActiveApiServletTest.java:112:
> error: no suitable method found for thenReturn(StringTokenizer)
> [javac]
> when(req.getHeaders("Authorization")).thenReturn(generateOAuthHeader(ROBOT.getAddress()));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
