[
https://issues.apache.org/jira/browse/WAVE-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167170#comment-13167170
]
[email protected] commented on WAVE-142:
----------------------------------------------------
bq. On 2011-12-07 17:31:21, Yuri Zelikov wrote:
bq. > LGTM
Can you please close this review request?
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3033/#review3704
-----------------------------------------------------------
On 2011-12-06 21:22:30, Ali Lown wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3033/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-06 21:22:30)
bq.
bq.
bq. Review request for wave and Yuri Zelikov.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implements clearing sub/super text style when the clear formatting button
is pressed as suggested in WAVE-142.
bq.
bq. Works by adding verticalAlign attribute to existing list of styles to
clear.
bq.
bq.
bq. This addresses bug WAVE-142.
bq. https://issues.apache.org/jira/browse/WAVE-142
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java
1211145
bq.
bq. Diff: https://reviews.apache.org/r/3033/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Compiled. Ran server, added text in a blip with sub + super styles.
Selected and clicked 'clear formatting button'. Style was removed.
bq.
bq.
bq. Thanks,
bq.
bq. Ali
bq.
bq.
> cannot clear formatting for sub/super-script
> --------------------------------------------
>
> Key: WAVE-142
> URL: https://issues.apache.org/jira/browse/WAVE-142
> Project: Wave
> Issue Type: Bug
> Priority: Minor
> Labels: StarterProject
>
> Once I used the sub or super script button in the editor toolbar, I cannot
> get rid of that markup again. In particular, the clear formatting button in
> the editor toolbar doesn't do the job.
> ---
> Issue imported from
> http://code.google.com/p/wave-protocol/issues/detail?id=141
> Owner: [email protected]
> Cc: [email protected]
> Label: Type-Defect
> Label: Priority-Medium
> Stars: 0
> State: open
> Status: New
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
