[
https://issues.apache.org/jira/browse/WAVE-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182323#comment-13182323
]
[email protected] commented on WAVE-321:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3432/
-----------------------------------------------------------
Review request for wave, Yuri Zelikov and Lennard de Rijk.
Summary
-------
Nothing exciting in this patch, just prevents the length being processed as <0
(causing a whole server crash) for an uncaught exception.
This lets the server boot (which is much more important that a few corrupt
deltas), and the rest of the persistence layer still leaves a SEVERE in my logs
to tell me about the corrupt delta in the wave.
As for how it got corrupt I don't know so I can't address that actual issue.
This addresses bug WAVE-321.
https://issues.apache.org/jira/browse/WAVE-321
Diffs
-----
/src/org/waveprotocol/box/server/persistence/file/FileDeltaCollection.java
1228763
Diff: https://reviews.apache.org/r/3432/diff
Testing
-------
I wrote, compiled and deployed. Then my server booted again.
Thanks,
Ali
> Exception during transforming deltas on start causes server to fail to start
> ----------------------------------------------------------------------------
>
> Key: WAVE-321
> URL: https://issues.apache.org/jira/browse/WAVE-321
> Project: Wave
> Issue Type: Bug
> Components: Server
> Environment: Debian sid.
> Reporter: Ali Lown
> Assignee: Ali Lown
> Priority: Critical
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> One of my waves has a corrupt delta (somehow) which is preventing the server
> from starting at all due to an exception not being handled.
> The stacktrace is:
> Exception in thread "main" java.lang.NegativeArraySizeException
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaCollection.readTransformedWaveletDelta(FileDeltaCollection.java:510)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaCollection.readTransformedDeltaFromRecord(FileDeltaCollection.java:435)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaCollection.access$100(FileDeltaCollection.java:64)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaCollection$1$1.hasNext(FileDeltaCollection.java:308)
> at
> org.waveprotocol.box.server.persistence.file.DeltaIndex.rebuildIndexFromDeltas(DeltaIndex.java:100)
> at
> org.waveprotocol.box.server.persistence.file.DeltaIndex.openForCollection(DeltaIndex.java:75)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaCollection.open(FileDeltaCollection.java:128)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaStore.open(FileDeltaStore.java:69)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaStore.lookup(FileDeltaStore.java:101)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaStore$3.fetchNext(FileDeltaStore.java:149)
> at
> org.waveprotocol.box.server.persistence.file.FileDeltaStore$3.hasNext(FileDeltaStore.java:161)
> at
> org.waveprotocol.box.server.waveserver.WaveMap.loadAllWavelets(WaveMap.java:682)
> at
> org.waveprotocol.box.server.waveserver.WaveServerImpl.initialize(WaveServerImpl.java:283)
> at
> org.waveprotocol.box.server.ServerMain.initializeServer(ServerMain.java:210)
> at org.waveprotocol.box.server.ServerMain.run(ServerMain.java:174)
> at org.waveprotocol.box.server.ServerMain.main(ServerMain.java:127)
> I am now working on a patch to enable the server to boot, simply ignoring the
> corrupt delta.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
