[
https://issues.apache.org/jira/browse/WAVE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189372#comment-13189372
]
[email protected] commented on WAVE-325:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3508/
-----------------------------------------------------------
(Updated 2012-01-19 20:49:33.627593)
Review request for wave, Michael MacFadden and Lennard de Rijk.
Changes
-------
Addressed comments
Summary
-------
The goal of this patch is to decouple the search implementation
(SearchProvider) from the waves accessing logic (WaveMap). It should allow for
alternative implementations of search providers - not dependent on concrete
implementation of waves loading and access. The biggest problem with current
implementation is that it requires to load all waves into memory on the server
start up. An alternative (not memory based) search implementation would allow
to load the waves lazily and evict later.
This addresses bug WAVE-325.
https://issues.apache.org/jira/browse/WAVE-325
Diffs (updated)
-----
src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java
PRE-CREATION
src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java
PRE-CREATION
src/org/waveprotocol/box/server/waveserver/QueryHelper.java PRE-CREATION
src/org/waveprotocol/box/server/waveserver/TokenQueryType.java PRE-CREATION
src/org/waveprotocol/box/server/waveserver/Wave.java PRE-CREATION
src/org/waveprotocol/box/server/waveserver/WaveMap.java 42eb62b
src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 4892dc3
src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java ca05900
test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java
PRE-CREATION
test/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriberTest.java
PRE-CREATION
test/org/waveprotocol/box/server/waveserver/WaveDigesterTest.java 9a49ab2
test/org/waveprotocol/box/server/waveserver/WaveMapTest.java 17ba0df
Diff: https://reviews.apache.org/r/3508/diff
Testing
-------
Thanks,
Yuri
> Decouple the search implementation from the waves persistence logic.
> --------------------------------------------------------------------
>
> Key: WAVE-325
> URL: https://issues.apache.org/jira/browse/WAVE-325
> Project: Wave
> Issue Type: Improvement
> Components: Server
> Reporter: Yuri Zelikov
> Assignee: Yuri Zelikov
>
> The goal of this patch is to decouple the search implementation
> (SearchProvider) from the waves accessing logic (WaveMap). It should allow
> for alternative implementations of search providers - not dependent on
> concrete implementation of waves loading and access. The biggest problem with
> current implementation is that it requires to load all waves into memory on
> the server start up. An alternative (not memory based) search implementation
> would allow to load the waves lazily and evict later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
