[ 
https://issues.apache.org/jira/browse/WAVE-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199744#comment-13199744
 ] 

[email protected] commented on WAVE-330:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3753/#review4800
-----------------------------------------------------------

Ship it!


LGTM.

- Michael


On 2012-02-03 11:18:36, Yuri Zelikov wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3753/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-03 11:18:36)
bq.  
bq.  
bq.  Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Make attachment links URL be relative instead of absolute - that should 
allow for attachment link to work even if the domain address changed.
bq.  
bq.  
bq.  This addresses bug WAVE-330.
bq.      https://issues.apache.org/jira/browse/WAVE-330
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/org/waveprotocol/wave/client/doodad/link/Link.java f5fb0e4 
bq.    src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java 
73a6cfc 
bq.  
bq.  Diff: https://reviews.apache.org/r/3753/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added attachment and verified that it can be downloaded.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Yuri
bq.  
bq.


                
> Make attachment link URL be relative instead of absolute.
> ---------------------------------------------------------
>
>                 Key: WAVE-330
>                 URL: https://issues.apache.org/jira/browse/WAVE-330
>             Project: Wave
>          Issue Type: Improvement
>          Components: Web Client
>            Reporter: Yuri Zelikov
>            Assignee: Yuri Zelikov
>
> Make attachment links URL be relative instead of absolute - that should allow 
> for attachment link to work even if the domain address changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to