Should fix bugs during wavelet commit and update. -------------------------------------------------
Key: WAVE-341 URL: https://issues.apache.org/jira/browse/WAVE-341 Project: Wave Issue Type: Bug Components: Server Reporter: Yuri Zelikov Priority: Critical Some RuntimeExceptions escape from subscribers in the WaveletNotificationDispatcher which out the subscriber in undefined state. The main issue is with ClientFrontendImpl, but the exceptions are caused deeper in the server. INFO: Submit to [WaveletName waveinabox.net/w+30Bat7I71UA/waveinabox.net/conv+root] by *******@waveinabox.net @ 6036 w ith 1 ops Mar 27, 2012 9:20:57 PM org.waveprotocol.box.server.waveserver.WaveletNotificationDispatcher waveletUpdate SEVERE: Runtime exception in update to wave bus subscriber org.waveprotocol.box.server.frontend.ClientFrontendImpl@278a8 423 java.lang.IllegalStateException: Subscription expected delta for [WaveletName waveinabox.net/w+30Bat7I71UA/waveinabox.ne t/conv+root] targeting 6016, was 6036 at com.google.common.base.Preconditions.checkState(Preconditions.java:172) at org.waveprotocol.box.server.frontend.WaveViewSubscription.checkUpdateVersion(WaveViewSubscription.java:202) at org.waveprotocol.box.server.frontend.WaveViewSubscription.onUpdate(WaveViewSubscription.java:142) at org.waveprotocol.box.server.frontend.UserManager.onUpdate(UserManager.java:76) at org.waveprotocol.box.server.frontend.ClientFrontendImpl.participantUpdate(ClientFrontendImpl.java:260) at org.waveprotocol.box.server.frontend.ClientFrontendImpl.waveletUpdate(ClientFrontendImpl.java:305) at org.waveprotocol.box.server.waveserver.WaveletNotificationDispatcher.waveletUpdate(WaveletNotificationDispatc her.java:125) at org.waveprotocol.box.server.waveserver.WaveletContainerImpl.notifyOfDeltas(WaveletContainerImpl.java:181) at org.waveprotocol.box.server.waveserver.LocalWaveletContainerImpl.submitRequest(LocalWaveletContainerImpl.java :104) at org.waveprotocol.box.server.waveserver.WaveServerImpl.submitDelta(WaveServerImpl.java:536) at org.waveprotocol.box.server.waveserver.WaveServerImpl.submitRequest(WaveServerImpl.java:338) at org.waveprotocol.box.server.frontend.ClientFrontendImpl.submitRequest(ClientFrontendImpl.java:219) at org.waveprotocol.box.server.frontend.WaveClientRpcImpl.submit(WaveClientRpcImpl.java:164) at org.waveprotocol.box.common.comms.WaveClientRpc$ProtocolWaveClientRpc$1.submit(WaveClientRpc.java:4459) at org.waveprotocol.box.common.comms.WaveClientRpc$ProtocolWaveClientRpc.callMethod(WaveClientRpc.java:4589) at org.waveprotocol.box.server.rpc.ServerRpcControllerImpl.run(ServerRpcControllerImpl.java:200) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) Mar 27, 2012 9:20:57 PM org.waveprotocol.box.server.waveserver.WaveServerImpl submitDelta -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira