[
https://issues.apache.org/jira/browse/WAVE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270688#comment-13270688
]
[email protected] commented on WAVE-346:
----------------------------------------------------
bq. On 2012-05-08 17:58:40, vjrj wrote:
bq. > Now works great, but still exist some errors in the console (but are not
related). Can be fixed with excludes in gwt.xml files, like:
bq. >
bq. > diff --git a/src/org/waveprotocol/wave/model/Model.gwt.xml
b/src/org/waveprotocol/wave/model/Model.gwt.xml
bq. > index cb25ecf..83bbcee 100644
bq. > --- a/src/org/waveprotocol/wave/model/Model.gwt.xml
bq. > +++ b/src/org/waveprotocol/wave/model/Model.gwt.xml
bq. > @@ -58,6 +58,8 @@
bq. > <source path="schema"/>
bq. >
bq. > <source path="version"/>
bq. > +
bq. > + <source path="testing"
excludes="**/*Test*.java,**/*Tests*.java,**/*ExtraAsserts.java,
**/*OpMatchers.java, **/*Response.java" />
bq. >
bq. > <source path="undo"/>
bq. >
bq. > New review or can we fix it, in this same review?
I guess it would be better if you could submit a new patch.
Thanks!
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5068/#review7689
-----------------------------------------------------------
On 2012-05-08 17:29:21, Yuri Zelikov wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5068/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-08 17:29:21)
bq.
bq.
bq. Review request for wave, Michael MacFadden, vjrj, and Ali Lown.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixes Waveharness - issue WAVE-346
bq.
bq.
bq. This addresses bug WAVE-346.
bq. https://issues.apache.org/jira/browse/WAVE-346
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/org/waveprotocol/box/webclient/client/StageTwoProvider.java 22557cf
bq. src/org/waveprotocol/box/webclient/client/StagesProvider.java 82e289b
bq. src/org/waveprotocol/box/webclient/client/WindowTitleHandler.java
PRE-CREATION
bq. src/org/waveprotocol/wave/client/StageTwo.java d9ac106
bq.
src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java
43e0553
bq.
bq. Diff: https://reviews.apache.org/r/5068/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally - WIAB and Waveharness compile/run.
bq.
bq.
bq. Thanks,
bq.
bq. Yuri
bq.
bq.
> ant waveharness-hosted task is broken
> -------------------------------------
>
> Key: WAVE-346
> URL: https://issues.apache.org/jira/browse/WAVE-346
> Project: Wave
> Issue Type: Bug
> Reporter: Vicente J. Ruiz Jurado
> Assignee: Yuri Zelikov
>
> Waveharness-hosted task is currently broken after the inclusion of
> SavedStateIndicator and WindowTitleHandler.
> Probably can be fixed moving then to other packages, or maybe we should use
> another approach to fix it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
