[
https://issues.apache.org/jira/browse/WAVE-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290438#comment-13290438
]
Svante Schubert commented on WAVE-310:
--------------------------------------
@Paulo Pires:
If I apply your patch given above (ie.
https://github.com/pires/wave/commit/34e44e1dfb0ac6e7820f4d4b71fe05837efed960)
to the current trunk (last commit Tue May 29 17:20:13 2012), the changed
AbstractTreeNode.java provoke the failure of the following tests:
org.waveprotocol.wave.client.paging.PointTest
org.waveprotocol.wave.client.wavepanel.block.pojo.PojoStructureTest
Nevertheless aside of the issue a worthy change to access the properties by
methods instead directly..
> Wave Server fails to compile
> ----------------------------
>
> Key: WAVE-310
> URL: https://issues.apache.org/jira/browse/WAVE-310
> Project: Wave
> Issue Type: Bug
> Components: Server
> Environment: Fedora 16 3.1.2-1.fc16.x86_64
> Java 1.7.0_01
> Ant 1.8.2
> Reporter: Sten Martinez
> Assignee: Yuri Zelikov
> Priority: Critical
>
> Build fails due to -Werror:
> [longfalcon@anduril trunk]$ ant compile-gwt
> Buildfile: /opt/java/wave/trunk/build.xml
> init-logging:
> [mkdir] Created dir: /opt/java/wave/trunk/build/logs
> [echo] Logging to
> /opt/java/wave/trunk/build/logs/build_2011-12-01_10-59-04.log
> init:
> [mkdir] Created dir: /opt/java/wave/trunk/build/proto
> [mkdir] Created dir: /opt/java/wave/trunk/build/messages
> [mkdir] Created dir: /opt/java/wave/trunk/build/src
> [mkdir] Created dir: /opt/java/wave/trunk/build/test
> [mkdir] Created dir: /opt/java/wave/trunk/build/coverage
> [mkdir] Created dir: /opt/java/wave/trunk/dist
> [mkdir] Created dir: /opt/java/wave/trunk/build/staging
> [mkdir] Created dir: /opt/java/wave/trunk/build/dep
> [mkdir] Created dir: /opt/java/wave/trunk/test_out
> compile-proto-dep:
> compile-proto:
> [javac] Compiling 11 source files to /opt/java/wave/trunk/build/proto
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:971:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.waveletIdPrefix_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:1022:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.knownWavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:1895:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.contributor_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:2430:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.participantId_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:2481:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.document_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:2952:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.wavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java:3461:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.appliedDelta_);
> [javac] ^
> [javac] error: warnings found and -Werror specified
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:472:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.operation_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:512:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.addressPath_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:2763:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.attribute_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:3174:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.oldAttribute_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:3225:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.newAttribute_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:3598:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.attributeUpdate_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:3998:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.end_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:4049:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.change_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:5110:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.component_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:5945:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.signature_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/federation/Proto.java:6874:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.certificate_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/profile/ProfilesProto.java:314:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.addresses_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/profile/ProfilesProto.java:1064:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.profiles_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/search/SearchProto.java:980:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.participants_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/search/SearchProto.java:1391:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.digests_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java:2031:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.capability_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java:2419:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.context_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/box/server/persistence/protos/ProtoDeltaStoreData.java:474:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.operation_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java:368:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.knownWavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java:1123:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.wavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java:1976:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.participant_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java:2027:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.document_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java:2640:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.contributor_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:368:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.knownWavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:1123:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.wavelet_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:1698:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.participant_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:1738:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.addedParticipant_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:1778:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.removedParticipant_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:1829:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.document_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:2586:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.contributor_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:2626:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.addedContributor_);
> [javac] ^
> [javac]
> /opt/java/wave/trunk/proto_src/org/waveprotocol/wave/diff/Diff.java:2666:
> warning: [static] static method should be qualified by type name, Builder,
> instead of by an expression
> [javac] super.addAll(values, result.removedContributor_);
> [javac] ^
> [javac] 1 error
> [javac] 39 warnings
> BUILD FAILED
> /opt/java/wave/trunk/build.xml:106: The following error occurred while
> executing this line:
> /opt/java/wave/trunk/build-macros.xml:70: Compile failed; see the compiler
> error output for details.
> Total time: 4 seconds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
