[
https://issues.apache.org/jira/browse/WAVE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742724#comment-14742724
]
Vicente J. Ruiz Jurado commented on WAVE-350:
---------------------------------------------
Hi [~pablojan].
Yes, thanks for the patch.
I've tested after resolving some failed hunks, and the patch is not working as
I was expecting: When I, lets say sing-in and I open a modified wave, the
modified diffs should be visible, right now, the diffs are only visible if you
have the modified wave opened).
This is how the old Google Wave worked. So you can see what part of a document
was modified. Right now, you only see the last document without diffs.
Anyway to colorize the diffs with the same colors than avatars sounds to me
also very necessary.
PS: I'll attach a new patch that applies to trunk, but yes, the review board
it's a better place to discuss this.
> Edition differences in a wave are only visible if the user has the wave opened
> ------------------------------------------------------------------------------
>
> Key: WAVE-350
> URL: https://issues.apache.org/jira/browse/WAVE-350
> Project: Wave
> Issue Type: Bug
> Components: Web Client
> Reporter: Vicente J. Ruiz Jurado
> Attachments: WAVE-DiffHighlightByParticipant.patch, diff-waves.png
>
>
> Procedure to reproduce it:
> - User vjrj edit some wave (user admin is a participant of that wave)
> - User admin open the wave and only see that the wave is modified (because of
> the green header) but doesn't see the differences
> - User vjrj make some more edits white user admin has the wave opened
> - User admin can now see the differences (with yellow/pink/strikethrough
> annotations)
> Attached a screenshot.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
